We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

clip test v2

clippy.c (text/plain), 15.14 KB, created by Marcel Bakker on 2017-04-07 12:25:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel Bakker

Created: 2017-04-07 12:25:17 UTC

Size: 15.14 KB

patch

obsolete

>/*
>    -- clippy.c
>    -- 0.0.2
>    -- testing SDL_ClipRectangle()
>    -- add 'clippy.bmp' to your folder for texture clipping
>    -
>    - result = a grey screen, with in the top-left a red rectangle, and some primitives mixed in
>            (viewport screen should be 1/4 size centered(180x120), with black borders)
>			(scale is tested with 1.0f, 2.5f    ; our 360x240 becomes a virtual 360x96)
>			(logical size is tested with w, h*2 ; our 360x240 becomes a virtual 360x480)
>
>Tested on:
>- windows 7 : with SDL 2.0.5
>- Debian 8 x11 (VM on windows 7) : with SDL 2.0.5
>
>
>
>observed problems: (some of these have been reported)
>
>
>-software render + viewport + clip_rectangle
>	, test 3,4,7 and 8 show this.
>+ bug ID #3612 (SDL_render_sw.c, line 368, SW_UpdateClipRect(): viewport offset is missing)
>
>-software render + viewport + SDL_RenderReadPixels
>	, the read offset is incorrect when a viewport is used
>	, can test this with taking a screen shot from test 3,4,7 and 8.
>+ (SDL_render_sw.c, line 842: viewport offset is added a second time)
>
>-Windows 7 opengl + SDL_RenderReadPixels
>	does NOT correspond to what is shown
>	, looks like its always a frame behind
>	, screen shots taken will be an image from the previous test... press 'r' to force a repaint
>+ ?Related? bug ID #3619 (different OS, debian did gave correct results for me)
>
>-SDL_SetRenderTarget(ren, target) + logical size
>	a logical size is set by default
>	, test 4 and 6 shows this, a logical-size is detected and used as a backup (line 212 in here)
>	, only the first time it is drawn correctly, press 'r' to refresh
>+ (SDL_render.c, line 1124: renderer->logical_w/h should be initialized to 0, not the texture->w/h)
>
>-opengl(es2) render + scale
>	default render and target texture give different visual results
>	, test 5,6 and 7,8 show this.
>+ 
>
>
>Draw primitives problems:
>note : SDL_RenderDrawRect() bugs are SDL_RenderDrawLines(multiple lines) bugs in reality.
>
>direct3d - windows {
>- SDL_RenderDrawRect
>	top-left + bottom-left pixels are drawn 2 times
>}
>software - all {
>- SDL_RenderDrawLine
>	1 pixel lines are not drawn
>}
>opengl(es2) - debian 8 {
>- SDL_RenderDrawLine
>	1 pixel lines are not drawn (gles2 does draw them)
>- SDL_RenderDrawRect
>	bottom-left pixel is drawn 2 times
>	bottom-right pixel is NOT always drawn
>}
>all - renderers - tested {
>- SDL_RenderDrawRect
>	0*0 width/height draws a negative 2*2 rectangle
>	1*1 width/height is not drawn
>+ SDL_RenderDrawRect() probably needs a few special checks...
>}
>
>after thoughts :
>+ the viewport is used in SDL_Render and in SDL_xxx_Render files
>  , see the clip- and read pixel problems for the software renderer
>  , can or shouldn't all this viewport stuff be done in SDL_Render only? ...
>+ clip-rect, scale and blend are not present in any of the test units...
>+ DrawRect inherits complexity from DrawLine, maybe it's better off with 4 rects and a fillrects call...
>
>todo: someone with high dpi support should add the flag and take a look
>todo: add more clip use-cases
>	: add Clip + RenderCopyEx tests
>*/
>#include <stdio.h>
>#include <stdint.h>
>#include <stdlib.h>
>#if defined(_WIN32)
>#include "SDL.h"
>#include <windows.h>
>#else
>#include "SDL2/SDL.h"
>#endif
>
>/*
>note : SDL_RenderReadPixels() is clipping to the viewport area
>    So, we cannot do a 'bare metal' reading when the viewport is used.
>    (Expected behavior i assume..., thus no automated-bmp-verification-test-units)
>
>note : When options like viewport, scale or logical-size are used
>    , there are a few things you must do in order to get the correct pixel-size for SDL_RenderReadPixels()
>    The example below should work in all cases.
>*/
>void take_screen_shot(SDL_Renderer* ren, const char* filename)
>{
>    SDL_Rect rc_screen;
>    float sx, sy;
>    SDL_Surface* surf_save;
>#ifdef TRUE
>	SDL_Rect v_tmp;
>	int w_tmp, h_tmp, wl_tmp, hl_tmp;
>	float x_tmp, y_tmp;
>	SDL_GetRendererOutputSize(ren, &w_tmp, &h_tmp);
>	SDL_RenderGetLogicalSize(ren, &wl_tmp, &hl_tmp);
>	SDL_RenderGetViewport(ren, &v_tmp);
>	SDL_RenderGetScale(ren, &x_tmp, &y_tmp);
>	printf("SDL_GetRendererOutputSize = %dx%d\n", w_tmp, h_tmp);
>	printf("SDL_RenderGetLogicalSize  = %dx%d\n", wl_tmp, hl_tmp);
>	printf("SDL_RenderGetViewport     = %dx%d - offset = %dx%d\n", v_tmp.w, v_tmp.h, v_tmp.x, v_tmp.y);
>	printf("SDL_RenderGetScale        = %.2fx%.2f\n", x_tmp, y_tmp);
>#endif
>
>    SDL_RenderGetViewport(ren, &rc_screen); // defaults to the same w/h as SDL_GetRendererOutputSize
>	SDL_RenderGetScale(ren, &sx, &sy);		// defaults to 1.0f
>	rc_screen.w = (int)(rc_screen.w * sx);
>    rc_screen.h = (int)(rc_screen.h * sy);
>    surf_save = SDL_CreateRGBSurfaceWithFormat(0, rc_screen.w, rc_screen.h, 32, SDL_PIXELFORMAT_RGB888);
>    if (!surf_save)
>        return;
>    if (SDL_RenderReadPixels(ren, NULL, SDL_PIXELFORMAT_RGB888, surf_save->pixels, surf_save->pitch) == 0) {
>        if (SDL_SaveBMP(surf_save, filename) == 0)
>            printf("[#] screen shot %s (%dx%d) taken.\n", filename, rc_screen.w, rc_screen.h);
>    }
>    SDL_FreeSurface(surf_save);
>}
>
>void testing_blend(SDL_Renderer* ren)
>{
>	int i;
>	SDL_Rect rc = { 110, 20, 0, 0};
>
>	SDL_SetRenderDrawBlendMode(ren, SDL_BLENDMODE_BLEND);
>	SDL_SetRenderDrawColor(ren, 32, 32, 32, 128);
>
>	for (i=0; i < 10; i++) {
>		SDL_RenderDrawLine(ren, 80, 20 + (i*5), 80 + i, 20 + (i*5));
>		SDL_RenderDrawPoint(ren, 100, 20 + (i*5));
>		SDL_RenderDrawRect(ren, &rc);
>		rc.x += 20;
>		SDL_RenderFillRect(ren, &rc);
>		rc.x -= 20;
>		rc.y += rc.h + 1;
>		rc.w = rc.h = 1 + i;
>	}
>
>	SDL_SetRenderDrawBlendMode(ren, SDL_BLENDMODE_NONE);
>}
>
>void fill_top_left_rectangle(SDL_Renderer* ren, SDL_Texture* text_img)
>{
>	// renderer clip tests
>	float sx, sy;
>	int w_log, h_log;
>    SDL_Rect rc_view
>		, rc_clip = { 20, 20, 40, 40}
>        , rc_draw = { 30, 30, 3000, 3000}
>		, rc_fill = { 50, 50, 3000, 3000};
>	SDL_Point pt;
>	SDL_Texture *target_text;
>
>    // clear with black (border color for viewport)
>    SDL_SetRenderDrawColor(ren, 0, 0, 0, SDL_ALPHA_OPAQUE);
>    SDL_RenderClear(ren);
>
>    // fill with grey
>    SDL_SetRenderDrawColor(ren, 127, 127, 127, SDL_ALPHA_OPAQUE);
>    SDL_RenderFillRect(ren, NULL);
>
>    // set clip and fill with red / or fill with texture
>    SDL_RenderSetClipRect(ren, &rc_clip);
>    if (text_img) {
>        SDL_RenderCopy(ren, text_img, NULL, NULL);
>    } else {
>        SDL_SetRenderDrawColor(ren, 255, 0, 0, SDL_ALPHA_OPAQUE);
>        SDL_RenderFillRect(ren, NULL);
>    }
>    // also test SDL's primitives:
>    SDL_SetRenderDrawColor(ren, 0, 0, 63, SDL_ALPHA_OPAQUE);
>    // drawline left->right through clipping area
>    SDL_RenderDrawLine(ren, -50, 40, 3000, 40);
>    // drawline up->down through clipping area
>	SDL_RenderDrawLine(ren, 40, -50, 40, 3000);
>	// drawline diagonal inside clipping area
>	SDL_RenderDrawLine(ren, 25, 35, 35, 25);
>    SDL_SetRenderDrawColor(ren, 0, 0, 127, SDL_ALPHA_OPAQUE);
>    // drawrect through clipping area
>    SDL_RenderDrawRect(ren, &rc_draw);
>    // fillrect through clipping area
>    SDL_RenderFillRect(ren, &rc_fill);
>    SDL_SetRenderDrawColor(ren, 0, 0, 255, SDL_ALPHA_OPAQUE);
>    // drawpoints through clipping area
>    for (pt.x=40, pt.y=40; pt.x < 3000; pt.x++, pt.y++)
>        SDL_RenderDrawPoints(ren, &pt, 1);
>    // reset clip
>    SDL_RenderSetClipRect(ren, NULL);
>
>	// no clipping
>	testing_blend(ren);
>
>	// copy (if) target texture on to default render
>	target_text = SDL_GetRenderTarget(ren);
>	if (target_text) {
>		// backup settings
>		SDL_RenderGetLogicalSize(ren, &w_log, &h_log);
>		if (w_log == 0 || h_log == 0) {
>			SDL_RenderGetScale(ren, &sx, &sy);
>			SDL_RenderGetViewport(ren, &rc_view);
>		}
>		SDL_SetRenderTarget(ren, NULL); // resets scale + viewport to default render settings
>		SDL_RenderCopy(ren, target_text, NULL, NULL);
>	}
>	SDL_RenderPresent(ren);
>	if (target_text) {
>		SDL_SetRenderTarget(ren, target_text);
>		if (w_log == 0 || h_log == 0) {
>			SDL_RenderSetScale(ren, sx, sy);
>			SDL_RenderSetViewport(ren, &rc_view);
>		} else
>			SDL_RenderSetLogicalSize(ren, w_log, h_log);
>	}
>}
>
>int msg_loop(SDL_Renderer* ren, SDL_Texture* text_img)
>{
>    SDL_Event ev;
>    int do_next = 0, dirty = 1;
>
>    while (do_next == 0) {
>        while (SDL_PollEvent(&ev)) {
>            switch (ev.type) {
>            case SDL_QUIT: do_next = -1; break;
>            case SDL_KEYDOWN:
>                switch(ev.key.keysym.sym) {
>                case SDLK_ESCAPE: do_next = -1; break;
>				case SDLK_SPACE: do_next = 1; break;
>				case SDLK_r: dirty = 1; break;
>				case SDLK_s: take_screen_shot(ren, "screenshot.bmp"); break;
>                default: break;
>                } break;
>			case SDL_MOUSEBUTTONDOWN: do_next = 1; break;
>			case SDL_WINDOWEVENT:
>				switch(ev.window.event) {
>				case SDL_WINDOWEVENT_CLOSE: do_next = -1; break;
>				case SDL_WINDOWEVENT_EXPOSED: dirty = 1; break;
>				default: break;
>				} break;
>            default: break;
>            }
>        }
>		if (dirty) {
>			dirty = 0;
>			fill_top_left_rectangle(ren, text_img);
>		}
>        SDL_Delay(33);
>	}
>    return (do_next != 1);
>}
>
>int render_clip_tests(SDL_Renderer* ren, SDL_RendererInfo* ren_info, SDL_Texture* text_img)
>{
>	SDL_Texture *sdl_text_target;
>    SDL_Rect rc_view;
>    int w, h, done;
>    SDL_GetRendererOutputSize(ren, &w, &h);
>
>    printf("[ ] Test 1.\n");
>    if (msg_loop(ren, text_img) != 0)
>        return 1;
>
>    printf("[ ] Test 2 (via target texture).\n");
>    if (!SDL_RenderTargetSupported(ren)) {
>        printf("[x] Renderer does not support target textures, skipping test\n");
>    } else {
>        sdl_text_target = SDL_CreateTexture(ren, ren_info->texture_formats[0], SDL_TEXTUREACCESS_TARGET, w, h);
>        SDL_SetRenderTarget(ren, sdl_text_target);
>        done = msg_loop(ren, text_img);
>        SDL_SetRenderTarget(ren, NULL);
>        SDL_DestroyTexture(sdl_text_target);
>        if (done) return 1;
>    }
>
>    printf("[ ] Test 3 (with viewport).\n");
>    rc_view.x = w/4, rc_view.y = h/4, rc_view.w = w/2, rc_view.h = h/2;
>    SDL_RenderSetViewport(ren, &rc_view);
>    done = msg_loop(ren, text_img);
>    SDL_RenderSetViewport(ren, NULL);
>    if (done) return 1;
>
>    printf("[ ] Test 4 (with viewport) (via target texture).\n");
>    if (!SDL_RenderTargetSupported(ren)) {
>        printf("[x] Renderer does not support target textures, skipping test\n");
>    } else {
>		sdl_text_target = SDL_CreateTexture(ren, ren_info->texture_formats[0], SDL_TEXTUREACCESS_TARGET, w, h);
>        SDL_SetRenderTarget(ren, sdl_text_target);
>        SDL_RenderSetViewport(ren, &rc_view);
>        done = msg_loop(ren, text_img);
>        SDL_RenderSetViewport(ren, NULL);
>        SDL_SetRenderTarget(ren, NULL);
>        SDL_DestroyTexture(sdl_text_target);
>        if (done) return 1;
>    }
>
>    printf("[ ] Test 5 (with scale).\n");
>    SDL_RenderSetScale(ren, 1.0f, 2.5f);
>    done = msg_loop(ren, text_img);
>    SDL_RenderSetScale(ren, 1.f, 1.f);
>    if (done) return 1;
>
>    printf("[ ] Test 6 (with scale) (via target texture).\n");
>    if (!SDL_RenderTargetSupported(ren)) {
>        printf("[x] Renderer does not support target textures, skipping test\n");
>    } else {
>		sdl_text_target = SDL_CreateTexture(ren, ren_info->texture_formats[0], SDL_TEXTUREACCESS_TARGET, w, h);
>        SDL_SetRenderTarget(ren, sdl_text_target);
>        SDL_RenderSetScale(ren, 1.0f, 2.5f);
>        done = msg_loop(ren, text_img);
>        SDL_RenderSetScale(ren, 1.f, 1.f);
>        SDL_SetRenderTarget(ren, NULL);
>        SDL_DestroyTexture(sdl_text_target);
>        if (done) return 1;
>    }
>
>	printf("[ ] Test 7 (with LogicalSize[viewport+scale]).\n");
>	SDL_RenderSetLogicalSize(ren, w, h*2);
>	done = msg_loop(ren, text_img);
>	SDL_RenderSetLogicalSize(ren, 0, 0);
>	if (done) return 1;
>
>	printf("[ ] Test 8 (with LogicalSize[viewport+scale]) (via target texture).\n");
>	if (!SDL_RenderTargetSupported(ren)) {
>		printf("[x] Renderer does not support target textures, skipping test\n");
>	} else {
>		sdl_text_target = SDL_CreateTexture(ren, ren_info->texture_formats[0], SDL_TEXTUREACCESS_TARGET, w, h);
>		SDL_SetRenderTarget(ren, sdl_text_target);
>		SDL_RenderSetLogicalSize(ren, w, h*2);
>		done = msg_loop(ren, text_img);
>		SDL_RenderSetLogicalSize(ren, 0, 0);
>		SDL_SetRenderTarget(ren, NULL);
>		SDL_DestroyTexture(sdl_text_target);
>		if (done) return 1;
>	}
>
>    return 0;
>}
>
>int main(int argc, char *argv[])
>{
>    SDL_Window* win;
>    SDL_Renderer* ren;
>    SDL_Surface* surf_img;
>    SDL_RendererInfo ren_driv_info, ren_info;
>    SDL_Event empty;
>    int i, j, done=0;
>#if defined(_WIN32)
>    AllocConsole();
>    freopen("CONOUT$", "w", stdout);
>#endif
>
>    if (SDL_Init(SDL_INIT_EVENTS) < 0) {
>        printf("[x] Could not initialize SDL: %s.\n", SDL_GetError());
>        return EXIT_FAILURE;
>    }
>    surf_img = SDL_LoadBMP("clippy.bmp");
>    printf("[#] press space/click mouse to continue, s for screen shot, r to refresh, esc to exit\n");
>
>    // test each video driver
>    for ( i=0; !done && i < SDL_GetNumVideoDrivers(); i++)
>    {
>        if (SDL_strcmp(SDL_GetVideoDriver(i),"dummy") == 0)
>            continue;
>        printf("\n\n[-] Requesting VideoDriver %s.\n", SDL_GetVideoDriver(i));
>        if (SDL_VideoInit(SDL_GetVideoDriver(i)) != 0) {
>            printf("[x] SDL_VideoInit error: %s\n", SDL_GetError());
>            continue;
>        }
>        
>        // test each render driver
>        for ( j=0; !done && j < SDL_GetNumRenderDrivers(); j++)
>        {
>            SDL_GetRenderDriverInfo(j, &ren_driv_info);
>            if (SDL_strcmp(ren_driv_info.name,"dummy") == 0)
>                continue;
>            printf("\n[-] Requesting renderer : %s.\n", ren_driv_info.name);
>            SDL_SetHint(SDL_HINT_RENDER_DRIVER, ren_driv_info.name);
>
>            win = SDL_CreateWindow("clippy", SDL_WINDOWPOS_UNDEFINED, SDL_WINDOWPOS_UNDEFINED, 360, 240, SDL_WINDOW_SHOWN);
>            if (!win) {
>                printf("[x] Could not create window: %s\n", SDL_GetError());
>                return EXIT_FAILURE;
>            }
>            ren = SDL_CreateRenderer(win, -1, SDL_RENDERER_ACCELERATED);
>            if (!ren) {
>                printf("[x] Could not create renderer: %s\n", SDL_GetError());
>                return EXIT_FAILURE;
>            }
>            SDL_GetRendererInfo(ren, &ren_info);
>
>            if (SDL_strcmp(ren_driv_info.name, ren_info.name) != 0) {
>                printf("[x] Requested renderer does not match obtained renderer! (%s).\n", ren_info.name);
>			} else {
>				// one test with fill-color
>				done = render_clip_tests(ren, &ren_info, NULL);
>				// and one test with fill-texture
>				if (!done && surf_img) {
>					SDL_Texture* text_img = SDL_CreateTextureFromSurface(ren, surf_img);
>					if (text_img) {
>						printf("\n[#] Testing texture clip.\n");
>						done = render_clip_tests(ren, &ren_info, text_img);
>						SDL_DestroyTexture(text_img);
>					}
>				}
>			}
>
>            SDL_DestroyRenderer(ren);
>            SDL_DestroyWindow(win);
>            while (SDL_PollEvent( &empty ))
>                ;
>
>        } // end renderer drivers loop
>
>        SDL_VideoQuit();
>    } // end video drivers loop
>
>    if (surf_img)
>        SDL_FreeSurface(surf_img);
>	SDL_Quit();
>    return 0;
>}

Actions: View

Attachments on bug 3612: 2714

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.