We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

patch

Use_GCC_s_atomic_loads_in_SDL_AtomicGet_and_SDL_AtomicGetPtr.patch (text/plain), 1.09 KB, created by James Legg on 2017-03-29 15:15:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: James Legg

Created: 2017-03-29 15:15:20 UTC

Size: 1.09 KB

patch

obsolete

># HG changeset patch
># User James Legg <jlegg@feralinteractive.com>
># Date 1490798902 -3600
>#      Wed Mar 29 15:48:22 2017 +0100
># Node ID 623e8891e091093ac94e7df0bd320c7007283ae2
># Parent  1300a3135d61cd6fc45cd578dcc506a6d831c897
>Use GCC's atomic loads in SDL_AtomicGet and SDL_AtomicGetPtr
>
>This fixes errors reported by address sanitizer, and generates simpler
>code on x86 architectures.
>
>diff -r 1300a3135d61 -r 623e8891e091 src/atomic/SDL_atomic.c
>--- a/src/atomic/SDL_atomic.c	Sun Mar 26 21:00:19 2017 +0200
>+++ b/src/atomic/SDL_atomic.c	Wed Mar 29 15:48:22 2017 +0100
>@@ -211,21 +211,29 @@
> int
> SDL_AtomicGet(SDL_atomic_t *a)
> {
>+#ifdef HAVE_GCC_ATOMICS
>+    return __atomic_load_n(&a->value, __ATOMIC_SEQ_CST);
>+#else
>     int value;
>     do {
>         value = a->value;
>     } while (!SDL_AtomicCAS(a, value, value));
>     return value;
>+#endif
> }
> 
> void *
> SDL_AtomicGetPtr(void **a)
> {
>+#ifdef HAVE_GCC_ATOMICS
>+    return __atomic_load_n(a, __ATOMIC_SEQ_CST);
>+#else
>     void *value;
>     do {
>         value = *a;
>     } while (!SDL_AtomicCASPtr(a, value, value));
>     return value;
>+#endif
> }
> 
> void

Actions: View

Attachments on bug 3620: 2709

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.