We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] A patch for the bug in SDL_CaptureMouse

CaptureMouseFix.patch (text/plain), 1.43 KB, created by Matthew on 2017-01-28 12:44:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthew

Created: 2017-01-28 12:44:08 UTC

Size: 1.43 KB

patch

obsolete

>diff -r ca523d8f1af2 src/video/windows/SDL_windowsevents.c
>--- a/src/video/windows/SDL_windowsevents.c	Wed Jan 25 22:24:54 2017 -0800
>+++ b/src/video/windows/SDL_windowsevents.c	Sat Jan 28 12:43:50 2017 +0000
>@@ -524,9 +524,14 @@
>                 } else if (isCapture) {
>                     /* we check for where Windows thinks the system cursor lives in this case, so we don't really lose mouse accel, etc. */
>                     POINT pt;
>+                    RECT hwndRect;
>                     GetCursorPos(&pt);
>-                    if (WindowFromPoint(pt) != hwnd) {  /* if in the window, WM_MOUSEMOVE, etc, will cover it. */
>-                        ScreenToClient(hwnd, &pt);
>+                    HWND currentHnd = WindowFromPoint( pt );
>+                    ScreenToClient( hwnd, &pt );
>+                    GetClientRect( hwnd, &hwndRect );
>+
>+                    /* if in the window, WM_MOUSEMOVE, etc, will cover it. */
>+                    if( currentHnd != hwnd || pt.x < 0 || pt.y < 0 || pt.x > hwndRect.right || pt.y > hwndRect.right ) {
>                         SDL_SendMouseMotion(data->window, 0, 0, (int) pt.x, (int) pt.y);
>                         SDL_SendMouseButton(data->window, 0, GetAsyncKeyState(VK_LBUTTON) & 0x8000 ? SDL_PRESSED : SDL_RELEASED, SDL_BUTTON_LEFT);
>                         SDL_SendMouseButton(data->window, 0, GetAsyncKeyState(VK_RBUTTON) & 0x8000 ? SDL_PRESSED : SDL_RELEASED, SDL_BUTTON_RIGHT);

Actions: View | Diff

Attachments on bug 3550: 2686 | 2690

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.