We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Proposed bugfix.

bugfix_issue_3096.patch (text/plain), 1.21 KB, created by Steffen Pankratz on 2016-10-10 17:29:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Steffen Pankratz

Created: 2016-10-10 17:29:45 UTC

Size: 1.21 KB

patch

obsolete

># HG changeset patch
># User Steffen Pankratz <kratz00@gmx.de>
># Date 1476116885 -7200
>#      Mon Oct 10 18:28:05 2016 +0200
># Node ID ac24211a8eec771dcf801ec2337629f2c5df4174
># Parent  6f9f7acc9d1ef481111100c7c5996cd8feb37863
>Fixed bug 3096 - SDL_BlitSurface with overlapping source and destination
>
>diff -r 6f9f7acc9d1e -r ac24211a8eec src/video/SDL_blit_copy.c
>--- a/src/video/SDL_blit_copy.c	Sun Oct 09 20:31:32 2016 +0200
>+++ b/src/video/SDL_blit_copy.c	Mon Oct 10 18:28:05 2016 +0200
>@@ -109,10 +109,20 @@
>         overlap = (src < (dst + h*dstskip));
>     }
>     if (overlap) {
>-        while (h--) {
>-            SDL_memmove(dst, src, w);
>-            src += srcskip;
>-            dst += dstskip;
>+        if ( dst < src ) {
>+                while ( h-- ) {
>+                        SDL_memmove(dst, src, w);
>+                        src += srcskip;
>+                        dst += dstskip;
>+                }
>+        } else {
>+                src += ((h-1) * srcskip);
>+                dst += ((h-1) * dstskip);
>+                while ( h-- ) {
>+                        SDL_memmove(dst, src, w);
>+                        src -= srcskip;
>+                        dst -= dstskip;
>+                }
>         }
>         return;
>     }

Actions: View | Diff

Attachments on bug 3096: 2242 | 2243 | 2244 | 2318 | 2319 | 2581

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.