We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] A patch adding out-of-bound logs

sdl2_gamecontroller_outofbound_log_20161002.diff (text/plain), 1.32 KB, created by ny00 on 2016-10-02 14:14:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ny00

Created: 2016-10-02 14:14:51 UTC

Size: 1.32 KB

patch

obsolete

>diff -r 0c04fc2c44b0 src/joystick/SDL_gamecontroller.c
>--- a/src/joystick/SDL_gamecontroller.c	Sat Oct 01 18:49:15 2016 -0400
>+++ b/src/joystick/SDL_gamecontroller.c	Sun Oct 02 17:03:47 2016 +0300
>@@ -26,6 +26,7 @@
> #include "SDL_assert.h"
> #include "SDL_sysjoystick.h"
> #include "SDL_hints.h"
>+#include "SDL_log.h"
> #include "SDL_gamecontrollerdb.h"
> 
> #if !SDL_EVENTS_DISABLED
>@@ -145,7 +146,11 @@
>         {
>             SDL_GameController *controllerlist;
> 
>-            if (event->jaxis.axis >= k_nMaxReverseEntries) break;
>+            if (event->jaxis.axis >= k_nMaxReverseEntries)
>+            {
>+                SDL_Log("SDL_GameControllerEventWatcher: Axis index %d too large, ignoring motion", (int)event->jaxis.axis);
>+                break;
>+            }
> 
>             controllerlist = SDL_gamecontrollers;
>             while (controllerlist) {
>@@ -176,7 +181,11 @@
>         {
>             SDL_GameController *controllerlist;
> 
>-            if (event->jbutton.button >= k_nMaxReverseEntries) break;
>+            if (event->jbutton.button >= k_nMaxReverseEntries)
>+            {
>+                SDL_Log("SDL_GameControllerEventWatcher: Button index %d too large, ignoring update", (int)event->jbutton.button);
>+                break;
>+            }
> 
>             controllerlist = SDL_gamecontrollers;
>             while (controllerlist) {

Actions: View | Diff

Attachments on bug 3438: 2570

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.