We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Proposed patch, v2

SDL-directinput-add-xbox-one-controllers-to-xinput-filter-v2.patch (text/plain), 3.44 KB, created by Mikkel Krautz on 2016-08-06 18:30:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mikkel Krautz

Created: 2016-08-06 18:30:16 UTC

Size: 3.44 KB

patch

obsolete

># HG changeset patch
># User Mikkel Krautz <mikkel@krautz.dk>
># Date 1470488960 -7200
>#      Sat Aug 06 15:09:20 2016 +0200
># Branch dinputjoystick
># Node ID 87eea025e112fb28293683f3a339705fe7dc7f9c
># Parent  e8281b14970c7ef0b3cc8205d057951edee1b57f
>Add Xbox One controller GUIDs to the XInput filter in the DirectInput joystick driver.
>
>The Windows 10 Anniversary Update (1607) breaks the method uses that SDL uses to
>detect XInput devices. That is, on Windows 10 Anniversary Update, it is no longer
>possible to query RAWINPUT for HID devices, and check for "IG_" in the device name.
>
>Presumably, this will be fixed in the future.
>
>This patch works around the issue by adding the Xbox One controller series to the
>well-known device list.
>
>This skips the more expensive RAWINPUT check for those devices, and causes them to
>be detected as XInput devices once again.
>
>diff -r e8281b14970c -r 87eea025e112 src/joystick/windows/SDL_dinputjoystick.c
>--- a/src/joystick/windows/SDL_dinputjoystick.c	Wed Aug 03 22:39:44 2016 +0200
>+++ b/src/joystick/windows/SDL_dinputjoystick.c	Sat Aug 06 15:09:20 2016 +0200
>@@ -240,11 +240,23 @@
>     static GUID IID_ValveStreamingGamepad = { MAKELONG(0x28DE, 0x11FF), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
>     static GUID IID_X360WiredGamepad = { MAKELONG(0x045E, 0x02A1), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
>     static GUID IID_X360WirelessGamepad = { MAKELONG(0x045E, 0x028E), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
>+    static GUID IID_XOneWiredGamepad = { MAKELONG(0x045E, 0x02FF), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
>+    static GUID IID_XOneWirelessGamepad = { MAKELONG(0x045E, 0x02DD), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
>+    static GUID IID_XOneNewWirelessGamepad = { MAKELONG(0x045E, 0x02D1), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
>+    static GUID IID_XOneSWirelessGamepad = { MAKELONG(0x045E, 0x02EA), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
>+    static GUID IID_XOneSBluetoothGamepad = { MAKELONG(0x045E, 0x02E0), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
>+    static GUID IID_XOneEliteWirelessGamepad = { MAKELONG(0x045E, 0x02E3), 0x0000, 0x0000, { 0x00, 0x00, 0x50, 0x49, 0x44, 0x56, 0x49, 0x44 } };
> 
>     static const GUID *s_XInputProductGUID[] = {
>         &IID_ValveStreamingGamepad,
>-        &IID_X360WiredGamepad,   /* Microsoft's wired X360 controller for Windows. */
>-        &IID_X360WirelessGamepad /* Microsoft's wireless X360 controller for Windows. */
>+        &IID_X360WiredGamepad,         /* Microsoft's wired X360 controller for Windows. */
>+        &IID_X360WirelessGamepad,      /* Microsoft's wireless X360 controller for Windows. */
>+        &IID_XOneWiredGamepad,         /* Microsoft's wired Xbox One controller for Windows. */
>+        &IID_XOneWirelessGamepad,      /* Microsoft's wireless Xbox One controller for Windows. */
>+        &IID_XOneNewWirelessGamepad,   /* Microsoft's updated wireless Xbox One controller (w/ 3.5 mm jack) for Windows. */
>+        &IID_XOneSWirelessGamepad,     /* Microsoft's wireless Xbox One S controller for Windows. */
>+        &IID_XOneSBluetoothGamepad,    /* Microsoft's Bluetooth Xbox One S controller for Windows. */
>+        &IID_XOneEliteWirelessGamepad  /* Microsoft's wireless Xbox One Elite controller for Windows. */
>     };
> 
>     size_t iDevice;

Actions: View | Diff

Attachments on bug 3403: 2543 | 2544

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.