We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Fix "format not a string literal" errors

Fix-format-not-a-string-literal-errors.patch (text/plain), 1.63 KB, created by Bastien Nocera on 2016-06-26 07:28:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bastien Nocera

Created: 2016-06-26 07:28:01 UTC

Size: 1.63 KB

patch

obsolete

>From caa72b271295ab5ea47d57a609bf64826e57cdfa Mon Sep 17 00:00:00 2001
>From: Bastien Nocera <hadess@hadess.net>
>Date: Sun, 26 Jun 2016 09:27:01 +0200
>Subject: [PATCH] Fix "format not a string literal" errors
>
>With GCC 6.1.
>
>https://bugzilla.libsdl.org/show_bug.cgi?id=3375
>---
> src/SDL_error.c         | 3 +++
> src/test/SDL_test_log.c | 3 +++
> 2 files changed, 6 insertions(+)
>
>diff --git a/src/SDL_error.c b/src/SDL_error.c
>index ace5cc3..452d531 100644
>--- a/src/SDL_error.c
>+++ b/src/SDL_error.c
>@@ -116,6 +116,8 @@ SDL_SetError(SDL_PRINTF_FORMAT_STRING const char *fmt, ...)
>     return -1;
> }
> 
>+#pragma GCC diagnostic push
>+#pragma GCC diagnostic ignored "-Wformat-nonliteral"
> /* This function has a bit more overhead than most error functions
>    so that it supports internationalization and thread-safe errors.
> */
>@@ -216,6 +218,7 @@ SDL_GetErrorMsg(char *errstr, int maxlen)
>     }
>     return (errstr);
> }
>+#pragma GCC diagnostic pop
> 
> /* Available for backwards compatibility */
> const char *
>diff --git a/src/test/SDL_test_log.c b/src/test/SDL_test_log.c
>index 097372e..69696f8 100644
>--- a/src/test/SDL_test_log.c
>+++ b/src/test/SDL_test_log.c
>@@ -50,6 +50,8 @@
>  *
>  * \return Ascii representation of the timestamp in localtime in the format '08/23/01 14:55:02'
>  */
>+#pragma GCC diagnostic push
>+#pragma GCC diagnostic ignored "-Wformat-nonliteral"
> char *SDLTest_TimestampToString(const time_t timestamp)
> {
>     time_t copy;
>@@ -64,6 +66,7 @@ char *SDLTest_TimestampToString(const time_t timestamp)
> 
>     return buffer;
> }
>+#pragma GCC diagnostic pop
> 
> /*
>  * Prints given message with a timestamp in the TEST category and INFO priority.
>-- 
>2.7.4

Actions: View | Diff

Attachments on bug 3375: 2514 | 2517

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.