We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch for xinput trigger bug.

10180.patch (text/plain), 1.44 KB, created by Gert-Jan Stolk on 2016-06-05 21:20:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gert-Jan Stolk

Created: 2016-06-05 21:20:10 UTC

Size: 1.44 KB

patch

obsolete

># HG changeset patch
># User GJ
># Date 1465161443 -7200
>#      Sun Jun 05 23:17:23 2016 +0200
># Node ID 4e361b64711d3d7a939a83c8a85c9e83af256f3a
># Parent  7cbfd97f143075520b8ada03bce451639da02a42
>Added a fix for xbox 360/xinput triggers being pressed by default at application
>startup.
>This is only a partial fix. Another issue is that on controller disconnect the
>trigger will appear pressed again for a single frame until the disconnected
>state is set.
>
>diff -r 7cbfd97f1430 -r 4e361b64711d src/joystick/SDL_gamecontroller.c
>--- a/src/joystick/SDL_gamecontroller.c	Mon May 23 15:29:25 2016 -0300
>+++ b/src/joystick/SDL_gamecontroller.c	Sun Jun 05 23:17:23 2016 +0200
>@@ -970,6 +970,16 @@
> 
>     SDL_PrivateLoadButtonMapping(&gamecontroller->mapping, pSupportedController->guid, pSupportedController->name, pSupportedController->mapping);
> 
>+    /* The triggers are mapped from -32768 to 32767, where -32768 is the 'unpressed' value */
>+    int leftTriggerMapping = gamecontroller->mapping.axes[SDL_CONTROLLER_AXIS_TRIGGERLEFT];
>+    if (leftTriggerMapping >= 0) {
>+        gamecontroller->joystick->axes[leftTriggerMapping] = (Sint16)-32768;
>+    }
>+    int rightTriggerMapping = gamecontroller->mapping.axes[SDL_CONTROLLER_AXIS_TRIGGERRIGHT];
>+    if (rightTriggerMapping >= 0) {
>+        gamecontroller->joystick->axes[rightTriggerMapping] = (Sint16)-32768;
>+    }
>+
>     /* Add joystick to list */
>     ++gamecontroller->ref_count;
>     /* Link the joystick in the list */

Actions: View | Diff

Attachments on bug 2823: 2481 | 2496

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.