We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Listen for blur and focus events on window instead of canvas

0012-Listen-for-blur-and-focus-events-on-window-instead-of-.txt (text/plain), 1.69 KB, created by Charlie Birks on 2016-04-12 15:08:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Birks

Created: 2016-04-12 15:08:51 UTC

Size: 1.69 KB

patch

obsolete

># HG changeset patch
># User Boris Gjenero <boris.gjenero@gmail.com>
>
>Listen for blur and focus events on window instead of canvas
>
>Blur and focus events were not arriving for the canvas in
>Firefox 35 and Chrome 40.
>---
> src/video/emscripten/SDL_emscriptenevents.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/src/video/emscripten/SDL_emscriptenevents.c b/src/video/emscripten/SDL_emscriptenevents.c
>index 770c952..5c660a5 100644
>--- a/src/video/emscripten/SDL_emscriptenevents.c
>+++ b/src/video/emscripten/SDL_emscriptenevents.c
>@@ -573,8 +573,8 @@ Emscripten_RegisterEventHandlers(SDL_WindowData *data)
> 
>     emscripten_set_wheel_callback("#canvas", data, 0, Emscripten_HandleWheel);
> 
>-    emscripten_set_focus_callback("#canvas", data, 0, Emscripten_HandleFocus);
>-    emscripten_set_blur_callback("#canvas", data, 0, Emscripten_HandleFocus);
>+    emscripten_set_focus_callback("#window", data, 0, Emscripten_HandleFocus);
>+    emscripten_set_blur_callback("#window", data, 0, Emscripten_HandleFocus);
> 
>     emscripten_set_touchstart_callback("#canvas", data, 0, Emscripten_HandleTouch);
>     emscripten_set_touchend_callback("#canvas", data, 0, Emscripten_HandleTouch);
>@@ -610,8 +610,8 @@ Emscripten_UnregisterEventHandlers(SDL_WindowData *data)
> 
>     emscripten_set_wheel_callback("#canvas", NULL, 0, NULL);
> 
>-    emscripten_set_focus_callback("#canvas", NULL, 0, NULL);
>-    emscripten_set_blur_callback("#canvas", NULL, 0, NULL);
>+    emscripten_set_focus_callback("#window", NULL, 0, NULL);
>+    emscripten_set_blur_callback("#window", NULL, 0, NULL);
> 
>     emscripten_set_touchstart_callback("#canvas", NULL, 0, NULL);
>     emscripten_set_touchend_callback("#canvas", NULL, 0, NULL);
>

Actions: View | Diff

Attachments on bug 3229: 2410 | 2411 | 2412 | 2413 | 2414 | 2415 | 2416 | 2417 | 2418 | 2419 | 2420 | 2421 | 2422 | 2423 | 2424 | 2425 | 2426 | 2427 | 2428 | 2429 | 2430 | 2431 | 2432

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.