We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Mouse events use CSS coordinates, so don't scale by pixel_ratio

0011-Mouse-events-use-CSS-coordinates-so-don-t-scale-by-pix.txt (text/plain), 1.67 KB, created by Charlie Birks on 2016-04-12 15:07:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Birks

Created: 2016-04-12 15:07:50 UTC

Size: 1.67 KB

patch

obsolete

># HG changeset patch
># User Boris Gjenero <boris.gjenero@gmail.com>
>
>Mouse events use CSS coordinates, so don't scale by pixel_ratio
>
>---
> src/video/emscripten/SDL_emscriptenevents.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/src/video/emscripten/SDL_emscriptenevents.c b/src/video/emscripten/SDL_emscriptenevents.c
>index a506477..770c952 100644
>--- a/src/video/emscripten/SDL_emscriptenevents.c
>+++ b/src/video/emscripten/SDL_emscriptenevents.c
>@@ -308,8 +308,8 @@ Emscripten_HandleMouseMove(int eventType, const EmscriptenMouseEvent *mouseEvent
>     /* rescale (in case canvas is being scaled)*/
>     double client_w, client_h, xscale, yscale;
>     emscripten_get_element_css_size(NULL, &client_w, &client_h);
>-    xscale = window_data->window->w / (client_w * window_data->pixel_ratio);
>-    yscale = window_data->window->h / (client_h * window_data->pixel_ratio);
>+    xscale = window_data->window->w / client_w;
>+    yscale = window_data->window->h / client_h;
> 
>     /* check for pointer lock */
>     int isPointerLockSupported = emscripten_get_pointerlock_status(&pointerlock_status);
>@@ -371,8 +371,8 @@ Emscripten_HandleMouseFocus(int eventType, const EmscriptenMouseEvent *mouseEven
>         double client_w, client_h;
>         emscripten_get_element_css_size(NULL, &client_w, &client_h);
> 
>-        mx = mx * (window_data->window->w / (client_w * window_data->pixel_ratio));
>-        my = my * (window_data->window->h / (client_h * window_data->pixel_ratio));
>+        mx = mx * (window_data->window->w / client_w);
>+        my = my * (window_data->window->h / client_h);
>         SDL_SendMouseMotion(window_data->window, 0, isPointerLocked, mx, my);
>     }
> 
>

Actions: View | Diff

Attachments on bug 3229: 2410 | 2411 | 2412 | 2413 | 2414 | 2415 | 2416 | 2417 | 2418 | 2419 | 2420 | 2421 | 2422 | 2423 | 2424 | 2425 | 2426 | 2427 | 2428 | 2429 | 2430 | 2431 | 2432

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.