We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] listen for mouse up on document (fixes mouseup outside canvas)

0004-listen-for-mouse-up-on-document-fixes-mouseup-outside-.txt (text/plain), 1.53 KB, created by Charlie Birks on 2016-04-12 14:59:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Birks

Created: 2016-04-12 14:59:05 UTC

Size: 1.53 KB

patch

obsolete

># HG changeset patch
># User Charlie Birks <admin@daftgames.net>
>
>listen for mouse up on document (fixes mouseup outside canvas)
>
>---
> src/video/emscripten/SDL_emscriptenevents.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/video/emscripten/SDL_emscriptenevents.c b/src/video/emscripten/SDL_emscriptenevents.c
>index 4e29b7d..24fa0a1 100644
>--- a/src/video/emscripten/SDL_emscriptenevents.c
>+++ b/src/video/emscripten/SDL_emscriptenevents.c
>@@ -540,7 +540,7 @@ Emscripten_RegisterEventHandlers(SDL_WindowData *data)
>     emscripten_set_mousemove_callback("#canvas", data, 0, Emscripten_HandleMouseMove);
> 
>     emscripten_set_mousedown_callback("#canvas", data, 0, Emscripten_HandleMouseButton);
>-    emscripten_set_mouseup_callback("#canvas", data, 0, Emscripten_HandleMouseButton);
>+    emscripten_set_mouseup_callback("#document", data, 0, Emscripten_HandleMouseButton);
> 
>     emscripten_set_mouseenter_callback("#canvas", data, 0, Emscripten_HandleMouseFocus);
>     emscripten_set_mouseleave_callback("#canvas", data, 0, Emscripten_HandleMouseFocus);
>@@ -577,7 +577,7 @@ Emscripten_UnregisterEventHandlers(SDL_WindowData *data)
>     emscripten_set_mousemove_callback("#canvas", NULL, 0, NULL);
> 
>     emscripten_set_mousedown_callback("#canvas", NULL, 0, NULL);
>-    emscripten_set_mouseup_callback("#canvas", NULL, 0, NULL);
>+    emscripten_set_mouseup_callback("#document", NULL, 0, NULL);
> 
>     emscripten_set_mouseenter_callback("#canvas", NULL, 0, NULL);
>     emscripten_set_mouseleave_callback("#canvas", NULL, 0, NULL);
>

Actions: View | Diff

Attachments on bug 3229: 2410 | 2411 | 2412 | 2413 | 2414 | 2415 | 2416 | 2417 | 2418 | 2419 | 2420 | 2421 | 2422 | 2423 | 2424 | 2425 | 2426 | 2427 | 2428 | 2429 | 2430 | 2431 | 2432

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.