We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] My proposed fix.

SDL_fillrect.diff (text/plain), 1017 bytes, created by Dávid Nagy on 2015-05-17 17:25:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dávid Nagy

Created: 2015-05-17 17:25:06 UTC

Size: 1017 bytes

patch

obsolete

>--- ../SDL_fillrect.c	2014-03-16 03:31:44.000000000 +0100
>+++ ../SDL2-2.0.3/src/video/SDL_fillrect.c	2015-05-17 18:44:33.000000000 +0200
>@@ -198,9 +198,15 @@
> static void
> SDL_FillRect3(Uint8 * pixels, int pitch, Uint32 color, int w, int h)
> {
>-    Uint8 r = (Uint8) ((color >> 16) & 0xFF);
>-    Uint8 g = (Uint8) ((color >> 8) & 0xFF);
>-    Uint8 b = (Uint8) (color & 0xFF);
>+#if SDL_BYTEORDER == SDL_LIL_ENDIAN
>+    Uint8 b1 = (Uint8) (color & 0xFF);
>+    Uint8 b2 = (Uint8) ((color >> 8) & 0xFF);
>+    Uint8 b3 = (Uint8) ((color >> 16) & 0xFF);
>+#elif SDL_BYTEORDER == SDL_BIG_ENDIAN
>+    Uint8 b1 = (Uint8) ((color >> 16) & 0xFF);
>+    Uint8 b2 = (Uint8) ((color >> 8) & 0xFF);
>+    Uint8 b3 = (Uint8) (color & 0xFF);
>+#endif
>     int n;
>     Uint8 *p = NULL;
> 
>@@ -209,9 +215,9 @@
>         p = pixels;
> 
>         while (n--) {
>-            *p++ = r;
>-            *p++ = g;
>-            *p++ = b;
>+            *p++ = b1;
>+            *p++ = b2;
>+            *p++ = b3;
>         }
>         pixels += pitch;
>     }

Actions: View | Diff

Attachments on bug 2986: 2155 | 2156

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.