We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch to fix corrupt UTF-8 messagebox titles.

sdl_title.patch (text/plain), 1.59 KB, created by Jason Wyatt on 2015-05-05 08:21:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jason Wyatt

Created: 2015-05-05 08:21:28 UTC

Size: 1.59 KB

patch

obsolete

># HG changeset patch
># User Jason Wyatt <jwyatt@feralinteractive.com>
># Date 1430813772 -3600
>#      Tue May 05 09:16:12 2015 +0100
># Node ID fad02cff468612c9dce664801f69abde32f69724
># Parent  e0e2e94ce5eafd7ed3c61cd065689624eba1d2b6
>Also set the _NET_WM_NAME. Window managers supporting this will take this value over the value set by XStoreName. This explicitly supports UTF-8 encoding, which fixes corrupt UTF-8 titles in KDE.
>
>diff -r e0e2e94ce5ea -r fad02cff4686 src/video/x11/SDL_x11messagebox.c
>--- a/src/video/x11/SDL_x11messagebox.c	Fri May 01 01:20:28 2015 -0400
>+++ b/src/video/x11/SDL_x11messagebox.c	Tue May 05 09:16:12 2015 +0100
>@@ -366,7 +366,7 @@
>     int x, y;
>     XSizeHints *sizehints;
>     XSetWindowAttributes wnd_attr;
>-    Atom _NET_WM_WINDOW_TYPE, _NET_WM_WINDOW_TYPE_DIALOG;
>+    Atom _NET_WM_WINDOW_TYPE, _NET_WM_WINDOW_TYPE_DIALOG, _NET_WM_NAME, UTF8_STRING;
>     Display *display = data->display;
>     SDL_WindowData *windowdata = NULL;
>     const SDL_MessageBoxData *messageboxdata = data->messageboxdata;
>@@ -401,6 +401,11 @@
>     }
> 
>     X11_XStoreName( display, data->window, messageboxdata->title );
>+    _NET_WM_NAME = X11_XInternAtom(display, "_NET_WM_NAME", False);
>+    UTF8_STRING = X11_XInternAtom(display, "UTF8_STRING", False);
>+    X11_XChangeProperty(display, data->window, _NET_WM_NAME, UTF8_STRING, 8,
>+                    PropModeReplace, (unsigned char *) messageboxdata->title,
>+                    strlen(messageboxdata->title) + 1 );
> 
>     /* Let the window manager know this is a dialog box */
>     _NET_WM_WINDOW_TYPE = X11_XInternAtom(display, "_NET_WM_WINDOW_TYPE", False);

Actions: View | Diff

Attachments on bug 2971: 2149 | 2693 | 2694

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.