We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Quick patch that covers most cases

SDL.patch (text/plain), 1.29 KB, created by Jason Wyatt on 2015-04-16 15:26:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jason Wyatt

Created: 2015-04-16 15:26:09 UTC

Size: 1.29 KB

patch

obsolete

># HG changeset patch
># User Jason Wyatt <jwyatt@feralinteractive.com>
># Date 1429197838 -3600
>#      Thu Apr 16 16:23:58 2015 +0100
># Node ID 49343474c92f57de8b25ef0ccb0ceeabdac30cdb
># Parent  d8ad01792399b0576148a42e2060ed5735ed54a0
>Wait for PropertyNotify events instead of ConfigureNotify events after calling ChangeProperty in SetWindowBordered
>
>diff -r d8ad01792399 -r 49343474c92f src/video/x11/SDL_x11window.c
>--- a/src/video/x11/SDL_x11window.c	Wed Apr 15 21:29:55 2015 +0200
>+++ b/src/video/x11/SDL_x11window.c	Thu Apr 16 16:23:58 2015 +0100
>@@ -54,9 +54,9 @@
> {
>     return ev->type == UnmapNotify && ev->xunmap.window == *((Window*)win);
> }
>-static Bool isConfigureNotify(Display *dpy, XEvent *ev, XPointer win)
>+static Bool isPropertyNotify(Display *dpy, XEvent *ev, XPointer win)
> {
>-    return ev->type == ConfigureNotify && ev->xconfigure.window == *((Window*)win);
>+    return ev->type == PropertyNotify && ev->xproperty.window == *((Window*)win);
> }
> 
> /*
>@@ -864,7 +864,7 @@
> 
>     SetWindowBordered(display, displaydata->screen, data->xwindow, bordered);
>     X11_XFlush(display);
>-    X11_XIfEvent(display, &event, &isConfigureNotify, (XPointer)&data->xwindow);
>+    X11_XIfEvent(display, &event, &isPropertyNotify, (XPointer)&data->xwindow);
> 
>     if (visible) {
>         XWindowAttributes attr;

Actions: View | Diff

Attachments on bug 2447: 2127

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.