We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] proposed patch

KHR_context_flush_control.diff (text/plain), 6.34 KB, created by Marc Di Luzio on 2015-03-06 17:28:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Di Luzio

Created: 2015-03-06 17:28:39 UTC

Size: 6.34 KB

patch

obsolete

># HG changeset patch
># User Marc Di Luzio <mdiluzio@feralinteractive.com>
># Date 1425657820 0
>#      Fri Mar 06 16:03:40 2015 +0000
># Node ID 64d9d79b7404d8581eaa83a9d7f7a95b4a7950a2
># Parent  0495816fec54aa44ea5651c245b1ae4a124172ec
>Allow setting of GL_CONTEXT_RELEASE_BEHAVIOR when creating the GL context when GLX_ARB_context_flush_control is available.
>
>This extension allows the user to specify whether a full flush is performed when making a context not current.
>The only way to set this currently is at context creation, so this patch provides that functionality.
>Defualt behaviour is set at FLUSH, as per the spec.
>
>This patch does not contain the changes to WGL, appleGL or other platforms as I do not have access to GL 4.5 hardware on those platforms.
>
>Full details on the use of KHR_context_flush_control can be found here:
>https://www.opengl.org/registry/specs/KHR/context_flush_control.txt
>
>diff -r 0495816fec54 -r 64d9d79b7404 include/SDL_opengl_glext.h
>--- a/include/SDL_opengl_glext.h	Mon Mar 02 21:36:45 2015 -0500
>+++ b/include/SDL_opengl_glext.h	Fri Mar 06 16:03:40 2015 +0000
>@@ -2988,6 +2988,11 @@
> #define GL_ARB_framebuffer_sRGB 1
> #endif /* GL_ARB_framebuffer_sRGB */
> 
>+#ifndef GL_KHR_context_flush_control
>+#define GL_CONTEXT_RELEASE_BEHAVIOR       0x82FB
>+#define GL_CONTEXT_RELEASE_BEHAVIOR_FLUSH 0x82FC
>+#endif /* GL_KHR_context_flush_control */
>+
> #ifndef GL_ARB_geometry_shader4
> #define GL_ARB_geometry_shader4 1
> #define GL_LINES_ADJACENCY_ARB            0x000A
>diff -r 0495816fec54 -r 64d9d79b7404 include/SDL_video.h
>--- a/include/SDL_video.h	Mon Mar 02 21:36:45 2015 -0500
>+++ b/include/SDL_video.h	Fri Mar 06 16:03:40 2015 +0000
>@@ -189,7 +189,8 @@
>     SDL_GL_CONTEXT_FLAGS,
>     SDL_GL_CONTEXT_PROFILE_MASK,
>     SDL_GL_SHARE_WITH_CURRENT_CONTEXT,
>-    SDL_GL_FRAMEBUFFER_SRGB_CAPABLE
>+    SDL_GL_FRAMEBUFFER_SRGB_CAPABLE,
>+    SDL_GL_CONTEXT_RELEASE_BEHAVIOR
> } SDL_GLattr;
> 
> typedef enum
>@@ -207,6 +208,12 @@
>     SDL_GL_CONTEXT_RESET_ISOLATION_FLAG    = 0x0008
> } SDL_GLcontextFlag;
> 
>+typedef enum
>+{
>+    SDL_GL_CONTEXT_RELEASE_BEHAVIOR_NONE   = 0x0000,
>+    SDL_GL_CONTEXT_RELEASE_BEHAVIOR_FLUSH  = 0x0001
>+} SDL_GLcontextReleaseFlag;
>+
> 
> /* Function prototypes */
> 
>diff -r 0495816fec54 -r 64d9d79b7404 src/video/SDL_sysvideo.h
>--- a/src/video/SDL_sysvideo.h	Mon Mar 02 21:36:45 2015 -0500
>+++ b/src/video/SDL_sysvideo.h	Fri Mar 06 16:03:40 2015 +0000
>@@ -303,6 +303,7 @@
>         int flags;
>         int profile_mask;
>         int share_with_current_context;
>+        int release_behavior;
>         int framebuffer_srgb_capable;
>         int retained_backing;
>         int driver_loaded;
>diff -r 0495816fec54 -r 64d9d79b7404 src/video/SDL_video.c
>--- a/src/video/SDL_video.c	Mon Mar 02 21:36:45 2015 -0500
>+++ b/src/video/SDL_video.c	Fri Mar 06 16:03:40 2015 +0000
>@@ -2637,6 +2637,7 @@
> #endif
>     _this->gl_config.flags = 0;
>     _this->gl_config.framebuffer_srgb_capable = 0;
>+    _this->gl_config.release_behavior = SDL_GL_CONTEXT_RELEASE_BEHAVIOR_FLUSH;
> 
>     _this->gl_config.share_with_current_context = 0;
> }
>@@ -2743,6 +2744,9 @@
>     case SDL_GL_FRAMEBUFFER_SRGB_CAPABLE:
>         _this->gl_config.framebuffer_srgb_capable = value;
>         break;
>+    case SDL_GL_CONTEXT_RELEASE_BEHAVIOR:
>+        _this->gl_config.release_behavior = value;
>+        break;
>     default:
>         retval = SDL_SetError("Unknown OpenGL attribute");
>         break;
>@@ -2845,6 +2849,13 @@
>         attrib = GL_SAMPLES;
> #endif
>         break;
>+    case SDL_GL_CONTEXT_RELEASE_BEHAVIOR:
>+#if SDL_VIDEO_OPENGL
>+        attrib = GL_CONTEXT_RELEASE_BEHAVIOR;
>+#else
>+        attrib = GL_CONTEXT_RELEASE_BEHAVIOR_KHR;
>+#endif
>+        break;
>     case SDL_GL_BUFFER_SIZE:
>         {
>             GLint bits = 0;
>diff -r 0495816fec54 -r 64d9d79b7404 src/video/x11/SDL_x11opengl.c
>--- a/src/video/x11/SDL_x11opengl.c	Mon Mar 02 21:36:45 2015 -0500
>+++ b/src/video/x11/SDL_x11opengl.c	Fri Mar 06 16:03:40 2015 +0000
>@@ -122,6 +122,13 @@
> #define GLX_LATE_SWAPS_TEAR_EXT 0x20F3
> #endif
> 
>+#ifndef GLX_ARB_context_flush_control
>+#define GLX_ARB_context_flush_control
>+#define GLX_CONTEXT_RELEASE_BEHAVIOR_ARB   0x2097
>+#define GLX_CONTEXT_RELEASE_BEHAVIOR_NONE_ARB           0x0000
>+#define GLX_CONTEXT_RELEASE_BEHAVIOR_FLUSH_ARB          0x2098
>+#endif
>+
> #define OPENGL_REQUIRES_DLOPEN
> #if defined(OPENGL_REQUIRES_DLOPEN) && defined(SDL_LOADSO_DLOPEN)
> #include <dlfcn.h>
>@@ -375,6 +382,11 @@
>     if (HasExtension("GLX_EXT_create_context_es2_profile", extensions)) {
>         _this->gl_data->HAS_GLX_EXT_create_context_es2_profile = SDL_TRUE;
>     }
>+
>+    /* Check for GLX_ARB_context_flush_control */
>+    if (HasExtension("GLX_ARB_context_flush_control", extensions)) {
>+        _this->gl_data->HAS_GLX_ARB_context_flush_control = SDL_TRUE;
>+    }
> }
> 
> /* glXChooseVisual and glXChooseFBConfig have some small differences in
>@@ -581,8 +593,8 @@
>             context =
>                 _this->gl_data->glXCreateContext(display, vinfo, share_context, True);
>         } else {
>-            /* max 8 attributes plus terminator */
>-            int attribs[9] = {
>+            /* max 10 attributes plus terminator */
>+            int attribs[11] = {
>                 GLX_CONTEXT_MAJOR_VERSION_ARB,
>                 _this->gl_config.major_version,
>                 GLX_CONTEXT_MINOR_VERSION_ARB,
>@@ -603,6 +615,15 @@
>                 attribs[iattr++] = _this->gl_config.flags;
>             }
> 
>+            /* only set if glx extension is available */
>+            if( _this->gl_data->HAS_GLX_ARB_context_flush_control ) {
>+                attribs[iattr++] = GLX_CONTEXT_RELEASE_BEHAVIOR_ARB;
>+                attribs[iattr++] = 
>+                    _this->gl_config.release_behavior ? 
>+                    GLX_CONTEXT_RELEASE_BEHAVIOR_FLUSH_ARB : 
>+                    GLX_CONTEXT_RELEASE_BEHAVIOR_NONE_ARB;
>+            }
>+
>             attribs[iattr++] = 0;
> 
>             /* Get a pointer to the context creation function for GL 3.0 */
>diff -r 0495816fec54 -r 64d9d79b7404 src/video/x11/SDL_x11opengl.h
>--- a/src/video/x11/SDL_x11opengl.h	Mon Mar 02 21:36:45 2015 -0500
>+++ b/src/video/x11/SDL_x11opengl.h	Fri Mar 06 16:03:40 2015 +0000
>@@ -35,6 +35,7 @@
>     SDL_bool HAS_GLX_EXT_visual_info;
>     SDL_bool HAS_GLX_EXT_swap_control_tear;
>     SDL_bool HAS_GLX_EXT_create_context_es2_profile;
>+    SDL_bool HAS_GLX_ARB_context_flush_control;
> 
>     Bool (*glXQueryExtension) (Display*,int*,int*);
>     void *(*glXGetProcAddress) (const GLubyte*);

Actions: View | Diff

Attachments on bug 2898: 2057

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.