We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] SDL_windowevents.c patch to fix dead keys

dead-keys-fix.patch (text/plain), 1.43 KB, created by Elisée Maurer on 2015-01-06 00:32:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Elisée Maurer

Created: 2015-01-06 00:32:50 UTC

Size: 1.43 KB

patch

obsolete

>diff -r 817656bd36ec src/video/windows/SDL_windowsevents.c
>--- a/src/video/windows/SDL_windowsevents.c Mon Jan 05 01:41:42 2015 -0500
>+++ b/src/video/windows/SDL_windowsevents.c Tue Jan 06 01:31:05 2015 +0100
>@@ -552,20 +552,6 @@
>                 SDL_SendKeyboardKey(SDL_PRESSED, code);
>             }
>         }
>-        if (msg == WM_KEYDOWN) {
>-            BYTE keyboardState[256];
>-            char text[5];
>-            UINT32 utf32 = 0;
>-
>-            GetKeyboardState(keyboardState);
>-            if (ToUnicode(wParam, (lParam >> 16) & 0xff, keyboardState, (LPWSTR)&utf32, 1, 0) > 0) {
>-                WORD repetition;
>-                for (repetition = lParam & 0xffff; repetition > 0; repetition--) {
>-                    WIN_ConvertUTF32toUTF8(utf32, text);
>-                    SDL_SendKeyboardText(text);
>-                }
>-            }
>-        }
>         returnCode = 0;
>         break;
> 
>@@ -595,8 +581,18 @@
>         break;
> 
>     case WM_UNICHAR:
>+        if (wParam == UNICODE_NOCHAR) {
>+            returnCode = 1;
>+            break;
>+        }
>+        // no break
>     case WM_CHAR:
>-        /* Ignore WM_CHAR messages that come from TranslateMessage(), since we handle WM_KEY* messages directly */
>+        {
>+            char text[5];
>+            
>+            WIN_ConvertUTF32toUTF8(wParam, text);
>+            SDL_SendKeyboardText(text);
>+        }
>         returnCode = 0;
>         break;
>

Actions: View | Diff

Attachments on bug 2834: 1984

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.