We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Proposed fix for this bug.

windows-msgbox-buttons.diff (text/plain), 1.26 KB, created by Jan Hellwig on 2015-01-03 11:28:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Hellwig

Created: 2015-01-03 11:28:40 UTC

Size: 1.26 KB

patch

obsolete

># HG changeset patch
># User Jan Hellwig <mail@jan-hellwig.com>
># Date 1420284142 -3600
>#      Sat Jan 03 12:22:22 2015 +0100
># Node ID 43e0206aff4f48e779a0c4dbeca5ff989a35b000
># Parent  e64d9374f1be0635e3a6713569f2864a424fd046
>Reversed button creation order for Windows message boxes in order to get correct behaviour when navigating with the arrow keys.
>
>diff --git a/src/video/windows/SDL_windowsmessagebox.c b/src/video/windows/SDL_windowsmessagebox.c
>--- a/src/video/windows/SDL_windowsmessagebox.c
>+++ b/src/video/windows/SDL_windowsmessagebox.c
>@@ -449,9 +449,9 @@
>     }
> 
>     /* Align the buttons to the right/bottom. */
>-    x = Size.cx - ButtonWidth - ButtonMargin;
>+    x = Size.cx - (ButtonWidth + ButtonMargin) * messageboxdata->numbuttons;
>     y = Size.cy - ButtonHeight - ButtonMargin;
>-    for (i = 0; i < messageboxdata->numbuttons; ++i) {
>+    for (i = messageboxdata->numbuttons - 1; i >= 0; --i) {
>         SDL_bool isDefault;
> 
>         if (buttons[i].flags & SDL_MESSAGEBOX_BUTTON_RETURNKEY_DEFAULT) {
>@@ -463,7 +463,7 @@
>             FreeDialogData(dialog);
>             return -1;
>         }
>-        x -= ButtonWidth + ButtonMargin;
>+        x += ButtonWidth + ButtonMargin;
>     }
> 
>     /* FIXME: If we have a parent window, get the Instance and HWND for them */

Actions: View

Attachments on bug 2832: 1981

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.