We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] applies the fixes listed in the comments

sdl.beos.diff (text/plain), 1.10 KB, created by Chris Roberts on 2006-12-07 18:43:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Roberts

Created: 2006-12-07 18:43:15 UTC

Size: 1.10 KB

patch

obsolete

>--- src/video/bwindow/SDL_sysvideo.cc.orig	2006-05-01 02:02:48.000000000 -0600
>+++ src/video/bwindow/SDL_sysvideo.cc	2006-12-07 16:27:49.000000000 -0700
>@@ -358,15 +358,25 @@
> 	                  (current.timing.h_total * current.timing.v_total);
> 
> 	modes = SDL_modelist[((bpp+7)/8)-1];
>-	for ( i=0; modes[i] && (modes[i]->w > width) &&
>-		      (modes[i]->h > height); ++i ) {
>-		/* still looking */
>+	bool exactmatch = false;
>+	for ( uint32 x = 0; modes[x]; x++ ) {
>+		if (modes[x]->w == width && modes[x]->h == height) {
>+			exactmatch = true;
>+			i = x;
>+			break;
>+		}
>+	}
>+	if ( ! exactmatch ) {
>+		for ( i=0; modes[i] && (modes[i]->w > width) &&
>+			      (modes[i]->h > height); ++i ) {
>+			/* still looking */
>+		}
> 	}
>-	if ( ! modes[i] || (modes[i]->w < width) || (modes[i]->h < width) ) {
>+	if ( ! modes[i] || (modes[i]->w < width) || (modes[i]->h < height) ) {
> 		--i;	/* We went too far */
> 	}
> 	width = modes[i]->w;
>-	height = modes[i]->h;      
>+	height = modes[i]->h;
> 	bscreen.GetModeList(&dmodes, &nmodes);
> 	for ( i = 0; i < nmodes; ++i ) {
> 		if ( (bpp == ColorSpaceToBitsPerPixel(dmodes[i].space)) &&

Actions: View | Diff

Attachments on bug 370: 184

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.