We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Small patch to test video driver cursor function are not NULL

SDL_cursor.diff (text/plain), 1.18 KB, created by Patrice Mandin on 2006-11-16 14:11:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Patrice Mandin

Created: 2006-11-16 14:11:12 UTC

Size: 1.18 KB

patch

obsolete

>--- SDL_cursor.c	2006-07-10 23:43:42.000000000 +0200
>+++ SDL_cursor.c.new	2006-11-16 20:04:48.000000000 +0100
>@@ -188,7 +188,7 @@
> 			   it needs to hide the old cursor before (possibly)
> 			   showing the new one.  (But don't erase NULL cursor)
> 			 */
>-			if ( SDL_cursor ) {
>+			if ( SDL_cursor && video->ShowWMCursor ) {
> 				video->ShowWMCursor(this, NULL);
> 			}
> 		}
>@@ -199,6 +199,7 @@
> 	if ( SDL_cursor && (SDL_cursorstate&CURSOR_VISIBLE) ) {
> 		/* Use window manager cursor if possible */
> 		if ( SDL_cursor->wm_cursor && 
>+			/* FIXME: check video->ShowWMCursor is not NULL */
> 	             video->ShowWMCursor(this, SDL_cursor->wm_cursor) ) {
> 			SDL_cursorstate &= ~CURSOR_USINGSW;
> 		} else {
>@@ -219,7 +220,9 @@
> 			SDL_EraseCursor(SDL_VideoSurface);
> 		} else {
> 			if ( video ) {
>-				video->ShowWMCursor(this, NULL);
>+				if ( video->ShowWMCursor ) {
>+					video->ShowWMCursor(this, NULL);
>+				}
> 			}
> 		}
> 	}
>@@ -248,7 +251,9 @@
> 				SDL_free(cursor->save[0]);
> 			}
> 			if ( video && cursor->wm_cursor ) {
>-				video->FreeWMCursor(this, cursor->wm_cursor);
>+				if ( video->FreeWMCursor ) {
>+					video->FreeWMCursor(this, cursor->wm_cursor);
>+				}
> 			}
> 			SDL_free(cursor);
> 		}

Actions: View | Diff

Attachments on bug 342: 183

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.