We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] possible patch

Android_video.c (text/plain), 2.19 KB, created by Thomas Faller on 2014-07-22 16:06:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Faller

Created: 2014-07-22 16:06:36 UTC

Size: 2.19 KB

patch

obsolete

>diff -r ddbca09f8f9d src/test/SDL_test_common.c
>--- a/src/test/SDL_test_common.c	Fri Jul 18 14:10:45 2014 -0700
>+++ b/src/test/SDL_test_common.c	Tue Jul 22 17:57:31 2014 +0200
>@@ -668,10 +668,13 @@
>         }
> 
>         /* Upload GL settings */
>+#ifndef __ANDROID__
>+		/* Color should be set by JNI */
>         SDL_GL_SetAttribute(SDL_GL_RED_SIZE, state->gl_red_size);
>         SDL_GL_SetAttribute(SDL_GL_GREEN_SIZE, state->gl_green_size);
>         SDL_GL_SetAttribute(SDL_GL_BLUE_SIZE, state->gl_blue_size);
>         SDL_GL_SetAttribute(SDL_GL_ALPHA_SIZE, state->gl_alpha_size);
>+#endif
>         SDL_GL_SetAttribute(SDL_GL_DOUBLEBUFFER, state->gl_double_buffer);
>         SDL_GL_SetAttribute(SDL_GL_BUFFER_SIZE, state->gl_buffer_size);
>         SDL_GL_SetAttribute(SDL_GL_DEPTH_SIZE, state->gl_depth_size);
>diff -r ddbca09f8f9d src/video/android/SDL_androidvideo.c
>--- a/src/video/android/SDL_androidvideo.c	Fri Jul 18 14:10:45 2014 -0700
>+++ b/src/video/android/SDL_androidvideo.c	Tue Jul 22 17:57:31 2014 +0200
>@@ -151,14 +151,39 @@
> 
> int
> Android_VideoInit(_THIS)
>-{
>+{	
>+	Uint32 mask;
>+	int bitCount;
>     SDL_DisplayMode mode;
>+	SDL_PixelFormat pixelFormat;
> 
>     mode.format = Android_ScreenFormat;
>     mode.w = Android_ScreenWidth;
>     mode.h = Android_ScreenHeight;
>     mode.refresh_rate = 0;
>     mode.driverdata = NULL;
>+	
>+	/* We need to set color sizes */
>+	
>+	if(!SDL_InitFormat(&pixelFormat, mode.format)){
>+		for(mask = pixelFormat.Rmask >> pixelFormat.Rshift,
>+			bitCount = 0; mask > 0; mask >>= 1)
>+			bitCount += 1;
>+		SDL_GL_SetAttribute(SDL_GL_RED_SIZE, bitCount);
>+		for(mask = pixelFormat.Gmask >> pixelFormat.Gshift,
>+			bitCount = 0; mask > 0; mask >>= 1)
>+			bitCount += 1;
>+        SDL_GL_SetAttribute(SDL_GL_GREEN_SIZE, bitCount);
>+		for(mask = pixelFormat.Bmask >> pixelFormat.Bshift,
>+			bitCount = 0; mask > 0; mask >>= 1)
>+			bitCount += 1;
>+        SDL_GL_SetAttribute(SDL_GL_BLUE_SIZE, bitCount);
>+		for(mask = pixelFormat.Amask >> pixelFormat.Ashift,
>+			bitCount = 0; mask > 0; mask >>= 1)
>+			bitCount += 1;
>+		SDL_GL_SetAttribute(SDL_GL_ALPHA_SIZE, bitCount);
>+	}
>+	
>     if (SDL_AddBasicVideoDisplay(&mode) < 0) {
>         return -1;
>     }

Actions: View | Diff

Attachments on bug 2291: 1488 | 1489 | 1490 | 1491 | 1492 | 1493 | 1501 | 1513 | 1721 | 1722 | 1726 | 1727 | 1741 | 1764 | 1765 | 1783

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.