We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch to use _beginthreadex on win32

createth-win32.patch.txt (text/plain), 1.19 KB, created by Alex Volkov on 2006-01-04 15:46:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Volkov

Created: 2006-01-04 15:46:17 UTC

Size: 1.19 KB

patch

obsolete

>Index: SDL_systhread.c
>===================================================================
>RCS file: /home/sdlweb/libsdl.org/cvs/SDL12/src/thread/win32/SDL_systhread.c,v
>retrieving revision 1.5
>diff -u -r1.5 SDL_systhread.c
>--- SDL_systhread.c	4 Jan 2004 16:49:19 -0000	1.5
>+++ SDL_systhread.c	4 Jan 2006 20:39:12 -0000
>@@ -30,13 +30,14 @@
> #include <stdio.h>
> #include <stdlib.h>
> #include <windows.h>
>+#include <process.h>
> 
> #include "SDL_error.h"
> #include "SDL_thread.h"
> #include "SDL_systhread.h"
> 
> 
>-static DWORD WINAPI RunThread(LPVOID data)
>+static unsigned __stdcall RunThread(void *data)
> {
> 	SDL_RunThread(data);
> 	return(0);
>@@ -44,9 +45,14 @@
> 
> int SDL_SYS_CreateThread(SDL_Thread *thread, void *args)
> {
>-	DWORD  threadnum;
>+	unsigned threadid;
> 
>-	thread->handle = CreateThread(NULL, 0, RunThread, args, 0, &threadnum);
>+	/* have to use _beginthreadex if we want the returned handle
>+	 * to be accessible after the thread exits
>+	 * threads created with _beginthread auto-close the handle
>+	 */
>+	thread->handle = (SYS_ThreadHandle) _beginthreadex(NULL, 0, RunThread,
>+			args, 0, &threadid);
> 	if (thread->handle == NULL) {
> 		SDL_SetError("Not enough resources to create thread");
> 		return(-1);

Actions: View | Diff

Attachments on bug 22: 16

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.