We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch (First fix).

patch (text/plain), 1.28 KB, created by John Knottenbelt on 2014-03-26 16:06:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John Knottenbelt

Created: 2014-03-26 16:06:21 UTC

Size: 1.28 KB

patch

obsolete

>exporting patch:
># HG changeset patch
># User John Knottenbelt <john@introversion.co.uk>
># Date 1395849808 0
>#      Wed Mar 26 16:03:28 2014 +0000
># Node ID 85c13076493052d61e4f3a7eda036a0befc97325
># Parent  7680f784d8503fe671ae73b6a3bbd9296d5ad9db
>Don't make window key if the application is not active.
>
>makeKeyAndOrderFront should not be called if the window is not
>active. See also https://bugzilla.libsdl.org/show_bug.cgi?id=2465
>
>diff -r 7680f784d850 -r 85c130764930 src/video/cocoa/SDL_cocoawindow.m
>--- a/src/video/cocoa/SDL_cocoawindow.m	Mon Mar 24 07:12:26 2014 -0400
>+++ b/src/video/cocoa/SDL_cocoawindow.m	Wed Mar 26 16:03:28 2014 +0000
>@@ -1231,7 +1231,14 @@
>      */
>     [windowData->listener pauseVisibleObservation];
>     if (![nswindow isMiniaturized] && [nswindow isVisible]) {
>-        [nswindow makeKeyAndOrderFront:nil];
>+        if ([NSApp isActive]) {
>+            [nswindow makeKeyAndOrderFront:nil];
>+        } else {
>+            /* If the application is not yet active, just bring the window to the front
>+               and wait for the application to become active before making it key.
>+               ( See https://bugzilla.libsdl.org/show_bug.cgi?id=2465 ) */
>+            [nswindow orderFront:nil];
>+        }
>     }
>     [windowData->listener resumeVisibleObservation];
>

Actions: View | Diff

Attachments on bug 2465: 1598

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.