We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch adding a SDL_AndroidGetLocale() function to get the locale of the phone, without static variables

sdl-android-locale.diff (text/plain), 2.52 KB, created by Julien Jorge on 2013-10-13 20:04:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julien Jorge

Created: 2013-10-13 20:04:51 UTC

Size: 2.52 KB

patch

obsolete

>diff -r 627f256b0e56 android-project/src/org/libsdl/app/SDLActivity.java
>--- a/android-project/src/org/libsdl/app/SDLActivity.java	Sat Oct 12 16:29:34 2013 -0300
>+++ b/android-project/src/org/libsdl/app/SDLActivity.java	Sun Oct 13 21:57:30 2013 +0200
>@@ -264,6 +264,10 @@
>         return mSingleton;
>     }
> 
>+    public static String getLocale() {
>+        return getContext().getResources().getConfiguration().locale.toString();
>+    }
>+
>     static class ShowTextInputTask implements Runnable {
>         /*
>          * This is used to regulate the pan&scan method to have some offset from
>diff -r 627f256b0e56 include/SDL_system.h
>--- a/include/SDL_system.h	Sat Oct 12 16:29:34 2013 -0300
>+++ b/include/SDL_system.h	Sun Oct 13 21:57:30 2013 +0200
>@@ -108,6 +108,19 @@
>  */
> extern DECLSPEC const char * SDLCALL SDL_AndroidGetExternalStoragePath();
> 
>+
>+/* Get the user's locale, as defined in the Activity.
>+
>+   Since the user can change the locale at any moment, the result of
>+   this function may not be constant during the time of the
>+   program. You may want to call it again after an
>+   SDL_APP_DIDENTEREFOREGROUND event.
>+
>+   The caller has the responsibility to release the returned string with
>+   SDL_free().
>+ */
>+extern DECLSPEC char * SDLCALL SDL_AndroidGetLocale();
>+
> #endif /* __ANDROID__ */
> 
> /* Ends C function definitions when using C++ */
>diff -r 627f256b0e56 src/core/android/SDL_android.c
>--- a/src/core/android/SDL_android.c	Sat Oct 12 16:29:34 2013 -0300
>+++ b/src/core/android/SDL_android.c	Sun Oct 13 21:57:30 2013 +0200
>@@ -1416,6 +1416,36 @@
>     return s_AndroidExternalFilesPath;
> }
> 
>+char * SDL_AndroidGetLocale()
>+{
>+    char *androidLocale;
>+
>+    struct LocalReferenceHolder refs = LocalReferenceHolder_Setup(__FUNCTION__);
>+    jmethodID mid;
>+    jstring localeString;
>+    const char *locale;
>+
>+    JNIEnv *env = Android_JNI_GetEnv();
>+    if (!LocalReferenceHolder_Init(&refs, env)) {
>+        LocalReferenceHolder_Cleanup(&refs);
>+        return NULL;
>+    }
>+
>+    /* localeString = SDLActivity.getLocale(); */
>+    mid = (*env)->GetStaticMethodID(env, mActivityClass,
>+            "getLocale","()Ljava/lang/String;");
>+    localeString =
>+        (jstring)(*env)->CallStaticObjectMethod(env, mActivityClass, mid);
>+    locale = (*env)->GetStringUTFChars(env, localeString, NULL);
>+    
>+    androidLocale = SDL_strdup(locale);
>+    (*env)->ReleaseStringUTFChars(env, localeString, locale);
>+
>+    LocalReferenceHolder_Cleanup(&refs);
>+
>+    return androidLocale;
>+}
>+
> #endif /* __ANDROID__ */
> 
> /* vi: set ts=4 sw=4 expandtab: */

Actions: View | Diff

Attachments on bug 2131: 1354 | 1366 | 1759 | 1788 | 4317 | 4320 | 4332

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.