We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch for SDL calling a wrong JNI function on Android.

sdl_wrong_jni_function_on_android_patch.diff (text/plain), 1.04 KB, created by Philipp Wiesemann on 2013-01-26 09:26:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philipp Wiesemann

Created: 2013-01-26 09:26:15 UTC

Size: 1.04 KB

patch

obsolete

>diff -r 436b5b8a5b98 src/core/android/SDL_android.cpp
>--- a/src/core/android/SDL_android.cpp	Sat Jan 26 12:31:55 2013 -0300
>+++ b/src/core/android/SDL_android.cpp	Sat Jan 26 18:23:54 2013 +0100
>@@ -430,12 +430,11 @@
>     }
>     Android_JNI_SetupThread();
> 
>-    
>     __android_log_print(ANDROID_LOG_VERBOSE, "SDL", "SDL audio: opening device");
>     audioBuffer16Bit = is16Bit;
>     audioBufferStereo = channelCount > 1;
> 
>-    env->CallStaticObjectMethod(mActivityClass, midAudioInit, sampleRate, audioBuffer16Bit, audioBufferStereo, desiredBufferFrames);
>+    env->CallStaticVoidMethod(mActivityClass, midAudioInit, sampleRate, audioBuffer16Bit, audioBufferStereo, desiredBufferFrames);
> 
>     /* Allocating the audio buffer from the Java side and passing it as the return value for audioInit no longer works on
>      * Android >= 4.2 due to a "stale global reference" error. So now we allocate this buffer directly from this side. */
>@@ -471,7 +470,7 @@
>     if (audioBufferStereo) {
>         audioBufferFrames /= 2;
>     }
>- 
>+
>     return audioBufferFrames;
> }
>

Actions: View | Diff

Attachments on bug 1703: 1028

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.