We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] path to remove a few redundant assigns

RemoveRedundantAssigns.patch (text/plain), 1.71 KB, created by Edward Rudd on 2013-01-12 14:32:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Edward Rudd

Created: 2013-01-12 14:32:26 UTC

Size: 1.71 KB

patch

obsolete

>tree 5b46fd5b8c94
>parent 971b278f0756
>author Edward Rudd <urkle@outoforder.cc> 1358022907 18000
>committer Edward Rudd <urkle@outoforder.cc> 1358022907 18000
>revision 6819
>branch default
>
>Remove some redundant assigns
>diff --git a/src/events/SDL_touch.c b/src/events/SDL_touch.c
>--- a/src/events/SDL_touch.c
>+++ b/src/events/SDL_touch.c
>@@ -125,7 +125,6 @@
>     SDL_memcpy(SDL_touchPads[index], touch, sizeof(*touch));
> 
>     /* we're setting the touch properties */
>-    length = 0;
>     length = SDL_strlen(name);
>     SDL_touchPads[index]->focus = 0;
>     SDL_touchPads[index]->name = SDL_malloc((length + 2) * sizeof(char));
>diff --git a/src/haptic/darwin/SDL_syshaptic.c b/src/haptic/darwin/SDL_syshaptic.c
>--- a/src/haptic/darwin/SDL_syshaptic.c
>+++ b/src/haptic/darwin/SDL_syshaptic.c
>@@ -173,7 +173,6 @@
>     /* IOServiceGetMatchingServices consumes dictionary. */
> 
>     if (!IOIteratorIsValid(iter)) {     /* No iterator. */
>-        numhaptics = 0;
>         return 0;
>     }
> 
>diff --git a/src/video/SDL_blit_A.c b/src/video/SDL_blit_A.c
>--- a/src/video/SDL_blit_A.c
>+++ b/src/video/SDL_blit_A.c
>@@ -258,7 +258,7 @@
> BlitRGBtoRGBSurfaceAlphaMMX(SDL_BlitInfo * info)
> {
>     SDL_PixelFormat *df = info->dst_fmt;
>-    Uint32 chanmask = df->Rmask | df->Gmask | df->Bmask;
>+    Uint32 chanmask;
>     unsigned alpha = info->a;
> 
>     if (alpha == 128 && (df->Rmask | df->Gmask | df->Bmask) == 0x00FFFFFF) {
>diff --git a/src/video/SDL_shape.c b/src/video/SDL_shape.c
>--- a/src/video/SDL_shape.c
>+++ b/src/video/SDL_shape.c
>@@ -71,7 +71,6 @@
>     SDL_Color key;
>     if(SDL_MUSTLOCK(shape))
>         SDL_LockSurface(shape);
>-    pixel = (Uint8*)shape->pixels;
>     for(y = 0;y<shape->h;y++) {
>         for(x=0;x<shape->w;x++) {
>             alpha = 0;

Actions: View | Diff

Attachments on bug 1691: 1017

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.