Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native MIDI on OS X does not loop #79

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Native MIDI on OS X does not loop #79

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 1.2.11
Reported for operating system, platform: Mac OS X (All), Other

Comments on the original bug report:

On 2010-01-17 10:22:23 +0000, Simon Howard wrote:

On Mac OS X, when playing a MIDI file with SDL_mixer with the "loops" parameter to Mix_PlayMusic set to 0 (loop forever), the music does not restart again once it has finished playing.

On 2011-09-06 09:56:42 +0000, Rene Dudfield wrote:

I can confirm this bug.

We are tracking this in the pygame bug tracker too at:
https://bitbucket.org/pygame/pygame/issue/44/pygamemixermusicplay-only-plays-once

On 2011-12-31 10:46:02 +0000, Sam Lantinga wrote:

*** Bug 955 has been marked as a duplicate of this bug. ***

On 2011-12-31 11:39:17 +0000, Ryan C. Gordon wrote:

Bumping priority on a few SDL_mixer bugs. This is just so we know to look at them for an upcoming release, but once we look at them more closely, we may decide to flag them as WONTFIX or push them back to a later release, so don't take this change in priority as any promise of anything, yet. :)

--ryan.

On 2011-12-31 15:48:55 +0000, Sam Lantinga wrote:

I'll take a look at this bug, I was just poking at the native midi code.

On 2011-12-31 19:41:00 +0000, Sam Lantinga wrote:

Just as a note, loops 0 means don't loop:
If 'loops' is greater than zero, loop the sound that many times.
If 'loops' is -1, loop inifinitely (~65000 times).

On 2011-12-31 21:49:48 +0000, Sam Lantinga wrote:

This is fixed, thanks!
http://hg.libsdl.org/SDL_mixer/rev/9ca74f21d466

On 2012-01-01 13:48:28 +0000, Sam Lantinga wrote:

Here is a better fix:
http://hg.libsdl.org/SDL_mixer/rev/f19368c22ebd

On 2012-01-01 15:49:40 +0000, Simon Howard wrote:

Great news, thanks!

On 2012-01-01 17:27:14 +0000, Sam Lantinga wrote:

You're welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant