Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_RecreateWindow strips SDL_WINDOW_FOREIGN from window flags #230

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

SDL_RecreateWindow strips SDL_WINDOW_FOREIGN from window flags #230

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.0
Reported for operating system, platform: Windows Vista, x86

Comments on the original bug report:

On 2009-11-23 06:59:48 +0000, Mason Wheeler wrote:

There's code in SDL_RecreateWindow specifically to handle SDL_WINDOW_FOREIGN, but it appears to have been overlooked in the allowed_flags constant. This causes the line

window->flags = (flags & allowed_flags);

to strip SDL_WINDOW_FOREIGN from the window's flags, which breaks some code in WIN_WindowProc in SDL_win32Events.c that treats foreign windows differently. This can be trivially fixed by defining allowed_flags as

const Uint32 allowed_flags = (SDL_WINDOW_FULLSCREEN |
                              SDL_WINDOW_OPENGL |
                              SDL_WINDOW_BORDERLESS |
                              SDL_WINDOW_RESIZABLE |
                              SDL_WINDOW_INPUT_GRABBED |
                              SDL_WINDOW_FOREIGN);

On 2009-11-23 21:00:04 +0000, Sam Lantinga wrote:

This is fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant