This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• patch for setting the input hint correctly (set-input-hint.patch, text/plain, 2009-09-26 16:58:32 +0000, 653 bytes)

Reported in version: 1.2.12
Reported for operating system, platform: Linux, x86

Comments on the original bug report:

On 2008-05-14 19:02:36 +0000, Vincent Povirk wrote:

DOSBox does not set the InputHint in the WM_HINTS property of its window on Linux. That means it can't get keyboard input in an ICCCM-compliant window manager.

This can be tested using the xprop command. A window with InputHint set will have a line that reads
Client accepts input or input focus: True
or
Client accepts input or input focus: False

This appears to be because DOSBox sets an icon. The create_aux_windows function in SDL_x11video.c sets a value for WM_HINTS that includes InputHint, but X11_SetIcon in SDL_x11wm.c overwrites that value with one that has set only icon-related hints.

I can't be entirely sure if that's what's happening, but patching X11_SetIcon does seem to fix the problem.

I originally reported this in a thread at DOSBox's forum: http://vogons.zetafleet.com/viewtopic.php?t=18516

On 2009-09-13 16:33:18 +0000, Ryan C. Gordon wrote:

Tagging this bug with "target-1.2.14" so we can try to resolve it for SDL 1.2.14.

Please note that we may choose to resolve it as WONTFIX. This tag is largely so we have a comprehensive wishlist of bugs to examine for 1.2.14 (and so we can close bugs that we'll never fix, rather than have them live forever in Bugzilla).

--ryan.

On 2009-09-13 18:35:37 +0000, Vincent Povirk wrote:

I'm actually not sure the bug is still present. I can't find the code that was broken in svn trunk.

I'll retest shortly.

On 2009-09-13 20:33:02 +0000, Vincent Povirk wrote:

This is still present in the 1.2 branch of sdl. I hadn't realized svn trunk was 1.3.

Given that this is an obvious deficiency with an easy fix, there's no good reason to leave it broken, even if it does not impact my own use of sdl and even if 1.2 will become obsolete.

Is there any further work I could do here? Is there somewhere I could send a patch?

On 2009-09-21 01:12:40 +0000, Sam Lantinga wrote:

You can attach a patch to this bug. That would be greatly appreciated, thanks!

On 2009-09-26 16:58:32 +0000, Vincent Povirk wrote:

Created attachment 377
patch for setting the input hint correctly

On 2009-09-26 18:31:44 +0000, Sam Lantinga wrote:

Thanks, your patch is in subversion!