Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for C++ compilation with -Wold-style cast #85

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Fixes for C++ compilation with -Wold-style cast #85

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: Linux, Other

Comments on the original bug report:

On 2008-01-07 16:20:21 +0000, wrote:

I try to get a clean compile for a project using SDL. But I get warnings
from SDL headers when I use -Wold-style-cast. This is especially bad
because I plan to build the software with -Werror=old-style-cast when we
have switched over to GCC 4.2, which has that option.

But this problem can be fixed in the SDL headers. I checked out the SVN
version and made some patches. See the attached patch.

On 2008-01-07 16:21:32 +0000, wrote:

Created attachment 243
Patch against current SVN.

On 2008-11-25 11:33:41 +0000, Sam Lantinga wrote:

Thank you very much for your patch for SDL 1.3!

Do you give me permission to release your code with SDL 1.3 and future
versions of SDL under both the LGPL and a closed-source commercial
license?

On 2008-12-28 03:59:43 +0000, wrote:

Yes, that patch can be used with any license. (It took a while to see your message here because this bugzilla is too old to have the feature to set an e-mail address (bug # 573).)

On 2009-02-16 20:58:11 +0000, Sam Lantinga wrote:

Thanks, this is fixed in revision 4431.

On 2009-04-01 23:17:13 +0000, Ozkan Sezer wrote:

This change should be applied to the 1.2 branch, too, because the svn version SDL_net requires it.

On 2009-04-01 23:18:25 +0000, Ozkan Sezer wrote:

Created attachment 313
Patch against current SDL-1.2 branch.

On 2009-10-08 00:46:08 +0000, Sam Lantinga wrote:

This is in for 1.2, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant