Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default path \TIMIDITY is awkward, please add e.g. C:\Windows\TIMIDITY #36

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: unspecified
Reported for operating system, platform: Windows (All), x86

Comments on the original bug report:

On 2007-11-18 05:32:54 +0000, wrote:

The default path \TIMIDITY has two problems:

  1. if the current drive is D:, and timidity.cfg is in C:\TIMIDITY,
    it won't be found. Relative drive names are almost never a good idea
    when looking for config files.

  2. On Wine, the default drive is usually Z:, the whole Linux
    drive. And we can't really put a symlink /timidity -> /etc/timidity
    just for Wine. But we could very easily arrange for e.g.
    C:\Windows\Timidity to point to /etc/timidity.

I'll attach a suggested patch. (Hi Sam!)

On 2007-11-18 05:34:40 +0000, wrote:

Created attachment 236
Patch to implement desired behavior without breaking current users

By the way, see http://bugs.winehq.org/show_bug.cgi?id=10492
for a recipe for reproducing the problem in real life.

On 2007-11-18 05:39:08 +0000, wrote:

I should mention that patch is untested, it's just to show the idea.

On 2008-07-07 08:49:54 +0000, Trygve Vea wrote:

A little advice

Instead of using C:, I'd suggest you fetch the environment variable %SYSTEMDRIVE%. Perhaps fall back on C: if the environment variable (for some reason) does not exist.

It is possible to remap the drives in Windows - a common process on Citrix-solutions. %SYSTEMDRIVE%\timidity\timidity.cfg should work regardless of the letter of the system drive.

Regards, Trygve

On 2009-10-03 02:51:40 +0000, Sam Lantinga wrote:

Hi Dan! :)

This is fixed for the next release. I default Windows to C:\TIMIDITY and added a TIMIDITY_CFG environment variable so you can fully specify the timidity.cfg file.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant