This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 1.2
Reported for operating system, platform: Windows (All), x86

Comments on the original bug report:

On 2007-11-10 22:18:13 +0000, Brian Fisher wrote:

If an app requests a 24-bit opengl mode on a machine with a 32-bit desktop with the windib video backend, then when exiting fullscreen the desktop resolution is not restored

The reason this is, is because the windib backend restores the desktop resolution when exiting fullscreen in DIB_SetVideoMode when it finds that the last request was for fullscreen by checking the original flags on the video surface. However, if the bits per pixel requested is different than current surface, the video surface is recreated and the original video flags are lost. So the check to see if we were exiting fullscreen fails.

below is a patch to SDL_dibvideo.c that solves the problem by using the original flags in all cases.

thanks!

---

Index: SDL_dibvideo.c

--- SDL_dibvideo.c (revision 3451)
+++ SDL_dibvideo.c (working copy)
@@ -484,6 +484,8 @@
int x, y;
Uint32 Rmask, Gmask, Bmask;

• prev_flags = current->flags;

• /* Clean up any GL context that may be hanging around */
  if ( current->flags & SDL_OPENGL ) {
  WIN_GL_ShutDown(this);
  @@ -531,7 +533,6 @@
  }

  /* Fill in part of the video surface */

• prev_flags = video->flags;
  prev_w = video->w;
  prev_h = video->h;
  video->flags = 0; /* Clear flags */

On 2007-12-28 00:00:59 +0000, Sam Lantinga wrote:

This is fixed with revision 3457, thanks!