This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Patch to support macrom gamma. (SDL-macrom-gamma.diff, text/plain, 2007-06-02 22:04:08 +0000, 4473 bytes)
• MacGamma code from ADC. (MacGamma.cpp, text/plain, 2007-06-02 22:04:51 +0000, 20562 bytes)
• Gamma ramp functions header from ADC. (MacGamma.h, text/plain, 2007-06-02 22:05:40 +0000, 4050 bytes)
• Updated patch. (SDL-macrom-gamma-2.diff, text/plain, 2007-06-02 23:54:58 +0000, 18130 bytes)
• Updated patch for macrom AND macdsp... (SDL-macclassic-gamma-3.diff, text/plain, 2007-06-03 12:40:57 +0000, 18538 bytes)

Reported in version: HG 1.2
Reported for operating system, platform: Mac OS Classic, PowerPC

Comments on the original bug report:

On 2007-06-02 21:59:58 +0000, Ryan C. Gordon wrote:

(Mailing list post in the URL field...)

Patch to add gamma ramp support to Mac OS Classic for SDL 1.2.

--ryan.

On 2007-06-02 22:04:08 +0000, Ryan C. Gordon wrote:

Created attachment 207
Patch to support macrom gamma.

Patch to macrom.

--ryan.

On 2007-06-02 22:04:51 +0000, Ryan C. Gordon wrote:

Created attachment 208
MacGamma code from ADC.

Source code from Apple Developer Connection to provide gamma ramp API.

--ryan.

On 2007-06-02 22:05:40 +0000, Ryan C. Gordon wrote:

Created attachment 209
Gamma ramp functions header from ADC.

Header file from Apple Developer Connection for those gamma ramp APIs.

--ryan.

On 2007-06-02 22:06:27 +0000, Ryan C. Gordon wrote:

I'd really like to get the MacGamma.c code merged into src/video/macrom/SDL_romvideo.c so that we don't have to change the project files.

--ryan.

On 2007-06-02 22:06:56 +0000, Ryan C. Gordon wrote:

(Bumping to P1 so it gets considered for 1.2.12...)

--ryan.

On 2007-06-02 23:54:58 +0000, Ryan C. Gordon wrote:

Created attachment 210
Updated patch.

Merged this all into one patch, cleaned it up a little.

--ryan.

On 2007-06-03 01:08:51 +0000, Ryan C. Gordon wrote:

CC'ing Greg...I can't get SDL to build on Mac OS Classic at all to test the updated patch. Can you try it and let me know if it works?

Thanks,
--ryan.

On 2007-06-03 07:52:33 +0000, Gregory Smith wrote:

I haven't applied it, but reading it, it looks like your new patch doesn't add gamma support to DrawSprocket, only the toolbox video driver.

If you don't mind having the MacGamma.c code duplicated in SDL_dspvideo and SDL_romvideo (that's why I had the file separate), I could see about a patch to both files that wouldn't require a new project file to be created.

On 2007-06-03 12:40:57 +0000, Ryan C. Gordon wrote:

Created attachment 211
Updated patch for macrom AND macdsp...

Whoops, I missed that in the original patch. I've moved the gamma code to maccommon, so now the changes to macdsp and macrom are extremely minimal.

Attaching patch against latest Subversion.

--ryan.

On 2007-06-10 19:10:55 +0000, Gregory Smith wrote:

OK I'm working on getting this to compile. For some reason I'm getting I'm getting undefined symbols for PBStatus, which is weird because MacGamma worked fine for me before. I'll let you know

On 2007-06-10 23:14:21 +0000, Ryan C. Gordon wrote:

I had that problem on OS X (PBStatusSync() isn't in Carbonlib)...I don't know what library it's in for Classic.

--ryan.

On 2007-06-14 18:02:47 +0000, Gregory Smith wrote:

Changing PBStatus(..., 0) to PBStatusAsync(...) fixed it. Compiled with the standard project file, and works great.

On 2007-06-14 23:31:37 +0000, Ryan C. Gordon wrote:

I tweaked it from PBStatusAsync() to PBStatusSync(), since that '0' says we need it synchronously, and appears to solve the linking issue without risk of a race condition.

This patch is now in source control, svn revision # 3073 for the 1.2 branch (and isn't applicable to the 1.3 branch).

When you get a moment, update to the latest in Subversion and make sure this still works. It should, so I'm resolving the bug, but just reopening it if I screwed something up.

Thanks for the legwork on this one, Gregory!

--ryan.