Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

png_const_bytep should not be used in libpng >= 14 #63

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

png_const_bytep should not be used in libpng >= 14 #63

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

SDLBugzilla commented Feb 11, 2021

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: unspecified
Reported for operating system, platform: Linux, x86

Comments on the original bug report:

On 2013-06-14 09:58:06 +0000, driedfruit wrote:

Created attachment 1191
patch to fix the issue

The ifdef/typedef define the "png_bytep" type, for libpng12, but there are 2 instances in the code, when raw "png_const_bytep" is still used.

This breaks libpng14 compile.

libtool: compile: gcc -DPACKAGE_NAME="" -DPACKAGE_TARNAME="" -DPACKAGE_VERSION="" -DPACKAGE_STRING="" -DPACKAGE_BUGREPORT="" -DPACKAGE_URL="" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=".libs/" -DPACKAGE="SDL2_image" -DVERSION="2.0.0" -DLOAD_PNG=1 -DLOAD_PNG_DYNAMIC="libpng14.so.14" -I. -I/usr/include/libpng14 -g -O2 -I/usr/local/include/SDL2 -D_REENTRANT -MT IMG_png.lo -MD -MP -MF .deps/IMG_png.Tpo -c IMG_png.c -fPIC -DPIC -o .libs/IMG_png.o
IMG_png.c:102: error: expected ‘)’ before ‘sig’
IMG_png.c:104: error: expected ‘;’ before ‘jmp_buf’

On 2014-07-03 21:36:41 +0000, Maarten ter Huurne wrote:

Created attachment 1731
Patch to provide png_const_bytep for libpng < 1.6

I encountered the same issue compiling SDL2_image-2.0.0 against libpng 1.4.13. I have an even smaller patch to solve the issue, see attachment.

On 2014-07-09 08:10:11 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL_image/rev/43873c313f32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant