Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new configure switch to disable the use of pthread_setname_np/pthread_set_name_np #688

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: Linux, All

Comments on the original bug report:

On 2012-10-27 10:49:56 +0000, Edward Rudd wrote:

Created attachment 979
Path to add new --enable-pthread-naming configure option

pthread_setname_np was added in glibc 2.12, however for better portability of games I prefer to require no newer than glibc 2.11 in my build system (CentOS/EPEL 6). However since that system uses 2.12 this one symbol messes with my glibc compatibility.

Currently I simply edit SDL_config.h post configure and build. So I propose this patch to simplify that process.

On 2012-10-27 14:30:03 +0000, Sam Lantinga wrote:

On Mac OS X we dynamically look up the symbol for that exact reason. Maybe we can do the same for other platforms?

On 2012-10-27 18:52:52 +0000, Edward Rudd wrote:

Hmm. that makes sense.. Now why wasn't that code shared then?? I'll see about converting the linux code to do the same and see if it flies.

On 2012-10-30 19:29:49 +0000, Sam Lantinga wrote:

Great, let me know what you find! :)

On 2012-11-03 10:23:36 +0000, Ryan C. Gordon wrote:

(In reply to comment # 3)

Great, let me know what you find! :)

(whoops, I replied on the mailing list, didn't realize we were discussing this here already.)

I just pushed a change to make the Linux and Mac OS X code do this. I think we're good here, so I'm closing the bug.

hg changeset 44a2e00e7c66 (and a minor fix in 45187a87d35b).

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant