Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11 touch initialisation does not check its file handles #610

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

X11 touch initialisation does not check its file handles #610

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: FreeBSD, All

Comments on the original bug report:

On 2012-06-27 23:58:11 +0000, Marcus von Appen wrote:

Created attachment 891
NULL pointer fix for X11_InitTouch()

On X11 a NULL pointer SIGSEGV might occur on call X11_InitTouch, if the user
has only limited access to /proc or if /proc is not mounted for whatever reason:

0 0x000000080107d88b in flockfile () from /lib/libc.so.7

1 0x0000000800fee6e3 in feof () from /lib/libc.so.7

2 0x0000000804310a58 in X11_InitTouch (_this=0x8016d7800)

at ../src/video/x11/SDL_x11touch.c:55

3 0x00000008043114ad in X11_VideoInit (_this=0x8016d7800)

at ../src/video/x11/SDL_x11video.c:371

4 0x00000008042f9b9a in SDL_VideoInit (driver_name=0x0)

It must be ensured that the return value of fopen("/proc/....") is not NULL.

On 2012-07-02 05:33:47 +0000, Sam Lantinga wrote:

Fixed, thanks!
http://hg.libsdl.org/SDL/rev/049721824c2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant