Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_RWops fails under Android 4 [patch] #590

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

SDL_RWops fails under Android 4 [patch] #590

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: Android (All), All

Comments on the original bug report:

On 2012-05-18 10:34:19 +0000, Gabriel Jacobo wrote:

Created attachment 859
Replaces some Android SDL_RWops local refs for globals

It seems that Android > v4.0 has a stricter policy referring to stale local references, as such some issues that before weren't obvious have arised.
For confirmation (besides my own experience) see:

http://forums.libsdl.org/viewtopic.php?t=8042
http://forums.libsdl.org/viewtopic.php?t=8057

The attached patch replaces those stale local references (references that are local but they are stored in the context anyway and are being used later, after they were freed) with global references. I think I've added the required global releases as well, and now SDL_RWops is working for me under Android.

On 2012-05-25 11:46:21 +0000, Gabriel Jacobo wrote:

Fixed in changeset 263e2c049c22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant