Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with non-ASCII chars in image paths in Windows 7 #44

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 1 comment
Closed

Problems with non-ASCII chars in image paths in Windows 7 #44

SDLBugzilla opened this issue Feb 11, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@SDLBugzilla
Copy link
Collaborator

SDLBugzilla commented Feb 11, 2021

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 1.2.12
Reported for operating system, platform: Windows 7, x86

Comments on the original bug report:

On 2012-04-27 14:18:14 +0000, Pere wrote:

Hi, at Tux Paint there is this bug report [1], a quick test with fopen(fname, "r")) goes right, so the images are accesible at the path described by fname.

An additional test is -with the file manager inside W7- to drag a image over showimage.exe, the results are that the image only displays if the chars of the path to the image are all ASCII.

[1] http://sourceforge.net/tracker/?func=detail&aid=3473049&group_id=66938&atid=516295

On 2012-05-24 13:54:03 +0000, Pere wrote:

Well, I followed the trace of the filaname passed to IMG_Load() up to the win32_file_open() function in the SDL-1.2.15/src/file/SDL_rwops.c file, it is unchanged untill arriving there, then it is recoded in this function, thus changing the path and avoiding to load the file.

If in win32_file_open() I force the use of filename as it is passed to the function ( h = CreateFile(filename, (w_right|r_right).....) instead of the recoded filenameW (h = CreateFileW(filenameW, (w_right|r_right), .....), then it loads right the images with non ascii chars on their path.

I don't provide a patch as I don't know enouth the code to understand what side effects this change can have.

Hope this helps
Pere

@sezero sezero added the wontfix This will not be worked on label Apr 16, 2021
@sezero
Copy link
Contributor

sezero commented Apr 16, 2021

This requires changes to SDL-1.2 RWops for windows, which won't happen. Closing.

@sezero sezero closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants