Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian patch: SDLNet_UDP_Bind does not behave as described #19

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Debian patch: SDLNet_UDP_Bind does not behave as described #19

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: unspecified
Reported for operating system, platform: Linux, Other

Comments on the original bug report:

On 2012-01-20 12:33:54 +0000, wrote:

Created attachment 792
UDP_Bind.patch

Debian contains the following patch since 2003. I don't know if it's been reported to upstream (it claims so) and I am doing it now in the case that it's useful.

http://bugs.debian.org/211570

The comment, which is the same as in the header file, describes one behaviour.

The code implements another: if channel is -1, it binds to the first channel
that has not yet been bound to the maximum number of addresses. The if
(binding->numbound... line should be just if ( binding->numbound) {
(i.e. choose an unused channel). (Although this may break any apps using the
incorrect behaviour.)

Debian changelog:

  • Changed comment for SDLNet_UDP_Bind to reflect implementation
    • Since upstream has not responded to this (and seems dead), and a fair
      number of packages use sdl-net, I don't want to change the behavior
      just for debian, only properly document the actual behavior.

Can you please comment?

On 2012-01-20 16:56:15 +0000, Sam Lantinga wrote:

Ouch. That's a pretty nasty bug. Thanks for reporting it!

Let me think about the best thing to do here...

On 2013-06-07 02:38:03 +0000, Sam Lantinga wrote:

The patch has been applied as-is, again so we don't break existing applications.

Thanks!

@SDLBugzilla SDLBugzilla added the bug Something isn't working label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant