Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_GetWindowSize() returns wrong size on iPhone retina and iPad #529

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.0
Reported for operating system, platform: iOS 4, x86

Comments on the original bug report:

On 2012-01-19 12:14:25 +0000, Vern Jensen wrote:

On iPhone retina display, SDL_GetDisplayMode() correctly returns 960x640 and 640x960. However, SDL_GetWindowSize() returns 480x320 or 320x480.

This inconsistent behavior is something I currently have to work around in my ported game that uses SDL_GetWindowSize() to determine if it needs to scale the image larger to fit the display. It currently scales it improperly due to getting the wrong size.

Window resize events from SDL also contain the wrong (too small) resolution size.

On 2012-01-19 17:58:22 +0000, Sam Lantinga wrote:

Hey Ryan, can you look at this when you dig into the retina display support?

On 2013-07-12 18:52:31 +0000, Ryan C. Gordon wrote:

(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.0, Priority 1.

This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.

On 2013-07-30 02:09:08 +0000, Ryan C. Gordon wrote:

The sad thing is that this was probably fixed six days after this report was opened, in this commit:

http://hg.libsdl.org/SDL/rev/ed2cf4669e55

I'm resolving this as FIXED, as a lot of work went into Retina support since this bug, and no one's noted it to be a problem recently.

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant