This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• final tweaks for full ios 3 compability (ios3compatibility.patch, text/plain, 2011-10-27 18:52:19 +0000, 2461 bytes)
• fix the inverted condition check (fix_inverted_condition.patch, text/plain, 2011-10-29 06:15:12 +0000, 620 bytes)
• better version check (responds_to_selector.patch, text/plain, 2011-10-29 06:15:51 +0000, 752 bytes)
• uikitviewcontroller update (uikitviewcontroller.patch, text/plain, 2011-10-29 06:17:08 +0000, 2081 bytes)
• uikitviewcontroller update updated (uikitviewcontroller.patch, text/plain, 2011-11-20 08:52:28 +0000, 1093 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: iOS (All), iPhone/iPod touch

Comments on the original bug report:

On 2011-08-06 04:03:17 +0000, Vittorio Giovara wrote:

In uikitvideo.m there a [uiscreen currentMode] call and then a consequent UIScreenMode that were introduced in iOS 3.2
This of course causes a crash when trying to run sdl code on iOS 3.1.* with an unimplemented excepition.

Should this be wrapped in a respondsToSelector or should compatibility with older versions be dropped?

On 2011-10-13 13:35:11 +0000, Kees Bakker wrote:

My repo at https://bitbucket.org/keestux/sdl already has somewhat of
a fix, but it would probably be more Objective-C to use respondsToSelector.
I'll make that change.

Having said that, with my current changes the code does not execute any
UIScreenMode related code if the iOS is older than 3.2. So I would think
it shouldn't crash anymore.

On 2011-10-27 18:52:19 +0000, Vittorio Giovara wrote:

Created attachment 720
final tweaks for full ios 3 compability

I've atteched some further tweaks

On 2011-10-29 03:16:27 +0000, Kees Bakker wrote:

Hi Vittorio, thanks for the patches

Perhaps we need to split them up.

1. bugfix using the inverted condition
2. using respondsToSelector instead of checking the version
3. the uikitcontroller change

About 3.
Is that change alright? What's the point of computing "frame" if it is not used?

On 2011-10-29 06:15:12 +0000, Vittorio Giovara wrote:

Created attachment 721
fix the inverted condition check

On 2011-10-29 06:15:51 +0000, Vittorio Giovara wrote:

Created attachment 722
better version check

On 2011-10-29 06:17:08 +0000, Vittorio Giovara wrote:

Created attachment 723
uikitviewcontroller update

On 2011-10-29 06:19:22 +0000, Vittorio Giovara wrote:

Kees, you are right about 3, I removed the computation instead.
Also I've split up the patches!

On 2011-11-08 01:15:30 +0000, Vittorio Giovara wrote:

Comment on attachment 721
fix the inverted condition check

this was applied in 2e4a1b92dc6f

On 2011-11-19 16:23:48 +0000, Ryan C. Gordon wrote:

Attachment # 722 is now hg changeset 30d57832687a, thanks!

What's the goal of Attachment # 723, though? Should we not check orientation when reporting screen dimensions?

--ryan.

On 2011-11-20 08:50:10 +0000, Vittorio Giovara wrote:

Comment on attachment 722
better version check

added in 30d57832687a

On 2011-11-20 08:52:28 +0000, Vittorio Giovara wrote:

Created attachment 728
uikitviewcontroller update updated

actually no, in the previous patch i got code mixed for another bug.
Please consider the version i uploaded now, it basically changes which uiscreen is going to provide teh screen size.

On 2011-11-27 20:31:50 +0000, Ryan C. Gordon wrote:

(In reply to comment # 11)

actually no, in the previous patch i got code mixed for another bug.
Please consider the version i uploaded now, it basically changes which uiscreen
is going to provide teh screen size.

This is now hg changeset a8696b259e09, thanks!

Resolving this bug as FIXED now, as I think we got everything taken care of at this point.

--ryan.