This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• X11: Added support to _NET_WM_PID and WM_CLIENT_MACHINE atoms (SDL-1.3) (SDL-add-support-for-_NET_WM_PID-in-x11-window-v1.patch, text/plain, 2011-06-27 10:53:44 +0000, 2718 bytes)
• X11: Move to XSetWMProperties and add support to _NET_WM_PID (SDL-1.3) (SDL-add-support-for-_NET_WM_PID-in-x11-window-v2.patch, text/plain, 2011-06-27 10:58:43 +0000, 4747 bytes)
• X11: Added support to _NET_WM_PID and WM_CLIENT_MACHINE atoms (SDL-1.2) (SDL-1.2-add-support-for-_NET_WM_PID-in-x11-window-v3.patch, text/plain, 2011-06-28 13:58:39 +0000, 1691 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2011-04-25 00:51:14 +0000, Jason Smith wrote:

This property has grown in value in both GNOME Shell and Unity desktop environments. It is also quite useful to applications such as Docky, AWN, Cairo Dock, and others. _NET_WM_PID is simple to set and should have no drawbacks.

On 2011-06-27 10:53:44 +0000, Marco Trevisan (Treviño) wrote:

Created attachment 636
X11: Added support to _NET_WM_PID and WM_CLIENT_MACHINE atoms (SDL-1.3)

This is a first implementation of _NET_WM_PID support in SDL 1.3.

As stated by freedesktop specs [1], it also needs that the running hostname is set, and this is done via the WM_CLIENT_MACHINE atom.

This actually applies only to SDL 1.3. Patch for 1.2 coming.

[1] http://standards.freedesktop.org/wm-spec/1.3/ar01s05.html#id2523510

On 2011-06-27 10:58:43 +0000, Marco Trevisan (Treviño) wrote:

Created attachment 637
X11: Move to XSetWMProperties and add support to _NET_WM_PID (SDL-1.3)

This is another implementation of the same patch which is using XSetWMProperties to set the main window properties including size, input and class hints plus WM_LOCALE_NAME.

The _NET_WM_PID atom is also set as before.

Chose the implementation that you prefer (this is working for SDL-1.3 only too).

On 2011-06-28 13:58:39 +0000, Marco Trevisan (Treviño) wrote:

Created attachment 639
X11: Added support to _NET_WM_PID and WM_CLIENT_MACHINE atoms (SDL-1.2)

Here you are the patch for SDL-1.2, I've just used XChangeProperty with Atoms instead of the convenience functions XSetWMProperties or XSetWMClientMachine because they both would give errors when compiling SDL without special configuration parameters (I can attach them too if requested, BTW).

@jason: I will send this also the patch to launchpad for being added to the libsdl1.2debian package.

On 2011-07-06 06:46:53 +0000, Martin Pitt wrote:

Reopening. This patch isn't in hg, and there is no indication why the bug was marked "fixed".

On 2012-01-06 23:08:30 +0000, Sam Lantinga wrote:

Thanks Marco, this was on the TODO list!
Your patches are applied to source control.